chore(theme): add primary text color variable for improved contrast #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for limit download text in header in apps-external/files_downloadlimit Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new CSS variable for primary text color to ensure better contrast in the default theme override.
- Adds
--color-primary-textmapped tovar(--color-text-maxcontrast) - Aims to enhance text readability against various backgrounds
Comments suppressed due to low confidence (1)
lib/Themes/OverrideDefaultTheme.php:153
- [nitpick] Consider adding a comment or updating the theme documentation to clarify where and how
--color-primary-textshould be used for consistency across the codebase.
'--color-primary-text' => 'var(--color-text-maxcontrast)',
printminion-co
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for limit download text in header in apps-external/files_downloadlimit.
This is an exhaustive alternative for nextcloud/files_downloadlimit#487, which still requires a css fix.