DRAFT: build(self-hosted): test self-hosted runner #18
Conversation
enable via: ./occ config:app:set --value yes --type string viewer always_show_viewer Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order later to use it as default viewer Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order later to display it for all not known mime types Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order to reuse it later Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Franziska Bath <[email protected]>
in order to be able to influence it later Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…component Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: Franziska Bath <[email protected]>
Don't include directories as they can not be displayed. Note: including directories could also cause a follow-up error with certain directory structures which happen to include a directory named like a number (i.e. 123) because of sloppy, too broad type casting in fileUtils.ts's genFileInfo() accidentally converting such a folder name to a Number, which then can not be used in string comparisons. Signed-off-by: Thomas Lehmann <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Reference the default mimetype from the config module, don't add a magic string. Signed-off-by: Thomas Lehmann <[email protected]>
== The bug The app config "always_show_viewer" enables the preview for all mimetypes. If this config is not set and no handler is registered for a mimetype, the file will be downloaded. In the share/public view, with this config enabled some file types were downloaded instead of opened in the preview. The code would not progress up to Viewer's openFileInfo() because it would not find a preview component candidate in [1] to even attempt opening the preview. == The fix As per reverse engineering it was found that special string "all" is used as symbol for handling any mimetype (at least in [2]). The decision was made to change the special mimetype for a registered previewer to "all", because then handling any file is already coverered this way. All discovered places: 1. Files/fileactions: getDefaultFileAction() [2] 2. Shares: attach(), "fileActionsReady" event handler, registerAction() call [3] [1]: https://github.com/nextcloud/server/blob/v29.0.6/apps/files/js/filelist.js#L912 [2]: https://github.com/nextcloud/server/blob/v29.0.6/apps/files/js/fileactions.js#L315 [3]: https://github.com/nextcloud/server/blob/v29.0.6/apps/files_sharing/src/share.js#L230 Signed-off-by: Thomas Lehmann <[email protected]>
== The error The text below the mimetype icon has Nextcloud's default text styling, which is dark text on light background, yet here it's dark background. == The fix The default component now defines a text color. Signed-off-by: Thomas Lehmann <[email protected]>
Another state will be added and this prepares for a consistent naming pattern.t Signed-off-by: Thomas Lehmann <[email protected]>
== The cause Previously the code attempted to load a preview of an image. If loading this preview image failed it was attempted to load the original image. Load errors of images were only handled _once_. This meant that a load error for the original image was never handled, thus the viewer was still in loading state and showed a browser-dependant "broken image" replacement icon. == The fix Now further image load errors are handled too. In case the original fails too, the loading state is ended and a placeholder text is shown. The default preview component, which was introduced to show something for any mimetype if configured, is now also used as a fallback. Signed-off-by: Thomas Lehmann <[email protected]>
For Safari 16.5/167.3 this fixes different icon sizes for the same mime type, visible when cycling through files with different file names. Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 similar comments
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
No description provided.