Skip to content

Conversation

@fracado
Copy link

@fracado fracado commented Feb 17, 2025

No description provided.

@fracado fracado force-pushed the fb/dev/fix-file-preview branch 2 times, most recently from 1046d0b to e7fdef1 Compare February 17, 2025 14:10
@fracado fracado force-pushed the fb/dev/fix-file-preview branch 2 times, most recently from 51b4e49 to e570185 Compare February 21, 2025 17:16
Copy link

@tanyaka tanyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to update the comment "don't include directories..." to something containing "... include only files with mimetypes"

No ";" at the end of line is needed too :-)

@matsaur
Copy link

matsaur commented Feb 24, 2025

Please consider to update the comment "don't include directories..." to something containing "... include only files with mimetypes"

No ";" at the end of line is needed too :-)

The idea behind the code is to not include directories, please use both wording in combination

@fracado fracado force-pushed the fb/dev/fix-file-preview branch from e570185 to fe7ccf1 Compare February 24, 2025 14:23
@fracado fracado force-pushed the fb/dev/fix-file-preview branch from fe7ccf1 to 98a3b0d Compare February 24, 2025 14:27
@fracado fracado requested a review from tanyaka February 24, 2025 14:32
@fracado fracado merged commit d845ff2 into ionos-dev Feb 25, 2025
3 of 6 checks passed
@fracado fracado deleted the fb/dev/fix-file-preview branch February 25, 2025 13:26
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants