Skip to content

IONOS: fix(Viewer): correctly display view action in shares action menu #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fracado wants to merge 1 commit into
base: ionos-dev
Choose a base branch
from
Open

IONOS: fix(Viewer): correctly display view action in shares action menu #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ import Download from 'vue-material-design-icons/Download.vue'
import Fullscreen from 'vue-material-design-icons/Fullscreen.vue'
import FullscreenExit from 'vue-material-design-icons/FullscreenExit.vue'
import Pencil from 'vue-material-design-icons/Pencil.vue'
import svgEye from '@mdi/svg/svg/eye.svg?raw'

// Dynamic loading
const NcModal = () => import(
Expand Down Expand Up @@ -937,6 +938,7 @@ export default defineComponent({
OCA.Files.fileActions.registerAction({
name: 'view',
displayName: t('viewer', 'View'),
icon: () => svgEye,
Copy link

@tanyaka tanyaka May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- icon: () => svgEye,
+ iconClass: 'icon-viewer',

I would propose to apply existing approach just to add a new iconClass property to data object as here. So we have less changes in

mime,
permissions: OC.PERMISSION_READ,
actionHandler: legacyFilesActionHandler,
Expand Down
Loading