Skip to content

Mk/dev/cleanup code #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
printminion-co merged 4 commits into from
Jun 23, 2025
Merged

Mk/dev/cleanup code #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4af55a8
IONOS: refactor(Default): remove unnecessary semicolons
printminion-co Jun 23, 2025
0af4370
IONOS: refactor(Viewer): simplify folder check logic in viewer action
printminion-co Jun 23, 2025
35019af
IONOS: refactor(Viewer): remove unnecessary semicolons
printminion-co Jun 23, 2025
3b92d35
IONOS: refactor(Viewer): remove unnecessary whitespace in node valida…
printminion-co Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/Default.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ export default {

computed: {
mimeIcon() {
return OC.MimeType.getIconUrl(this.mime);
}
return OC.MimeType.getIconUrl(this.mime)
},
},

mounted() {
this.doneLoading();
this.doneLoading()
},
}
</script>
Expand Down
5 changes: 1 addition & 4 deletions src/files_actions/viewerAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,7 @@ export function registerViewerAction() {
// Always enabled if configured so
if (configModule.alwaysShowViewer) {
// disable for folders
if (nodes.some(node => node.type === 'folder')) {
return false
}
return true
return !nodes.some(node => node.type === 'folder')
}

return nodes.every((node) =>
Expand Down
11 changes: 4 additions & 7 deletions src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,11 +741,11 @@ export default defineComponent({
// and office documents/pdfs to exclude collabora files
// otherwise accept all mimes
filteredFiles = fileList.filter(file => {
const mime = file?.mime;
const isOfficeDocument = mime && OC.MimeTypeList.aliases[mime]?.startsWith('x-office');
const isPdf = mime && mime === 'application/pdf';
const mime = file?.mime
const isOfficeDocument = mime && OC.MimeTypeList.aliases[mime]?.startsWith('x-office')
const isPdf = mime && mime === 'application/pdf'

return mime && !isOfficeDocument && !isPdf;
return mime && !isOfficeDocument && !isPdf
})
} else {
// filter out the unwanted mimes
Expand Down Expand Up @@ -990,9 +990,6 @@ export default defineComponent({
if (nodes.some(node => !(node.isDavRessource && node.root?.startsWith('/files')))) {
return false
}



// Faster to check if at least one node doesn't match the requirements
return !nodes.some(node => (
(node.permissions & Permission.READ) === 0
Expand Down
Loading