Fix password policy build #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printminion-co
force-pushed
the
dev/fix/password_policy_build
branch
2 times, most recently
from
8203528 to
5a4ba39
Compare
Signed-off-by: copilot Claude Sonnet 4.5 Co-authored-by: Tatjana Kaschperko Lindt <[email protected]>
tanyaka
force-pushed
the
dev/fix/password_policy_build
branch
from
5a4ba39 to
5fb7365
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for building apps that require dev dependencies during the build process. The password_policy app is moved to a new build category that includes dev dependencies when running composer.
- Adds a new
COMPOSER_INSTALL_WITH_DEVcommand that installs composer dependencies including dev packages - Creates a new
FULL_BUILD_WITH_DEV_APPScategory for apps requiring dev dependencies during build - Implements corresponding build targets and functions following existing patterns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Common build commands | ||
| COMPOSER_INSTALL = composer install --no-dev -o --no-interaction | ||
| COMPOSER_INSTALL_WITH_DEV = composer install -o --no-interaction --no-scripts && composer run-script post-install-cmd --no-interaction 2>/dev/null || true |
There was a problem hiding this comment.
Error suppression with 2>/dev/null || true hides all failures of the post-install-cmd script, making debugging difficult if the build silently fails. Consider allowing errors to propagate or at least logging them, especially since this is specifically for dev dependencies where build failures should be caught early.
Suggested change
| COMPOSER_INSTALL_WITH_DEV = composer install -o --no-interaction --no-scripts && composer run-script post-install-cmd --no-interaction 2>/dev/null || true | |
| COMPOSER_INSTALL_WITH_DEV = composer install -o --no-interaction --no-scripts && composer run-script post-install-cmd --no-interaction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.