feat(submodule-workflow): create pre-release and update IONOS submodu…

[printminion-co]

…le PR on ncw-server

[Copilot]

Pull Request Overview

This PR transforms the workflow from a simple repository dispatch trigger to a comprehensive automated release and submodule update system. The workflow now creates GitHub pre-releases and automatically generates pull requests in the ncw-server repository when changes are merged to the main branch.

• Creates pre-releases with auto-generated release notes for each commit to main
• Automatically updates the IONOS submodule in ncw-server repository and creates a PR
• Migrates from self-hosted to ubuntu-latest runners

Comments suppressed due to low confidence (1)

.github/workflows/submodule-trigger-workflow.yml:9

• The workflow doesn't include concurrency controls, which means multiple pushes to main in quick succession could create multiple pre-releases with the same short SHA (if commits have the same first 7 characters) or trigger multiple PR creation attempts. Consider adding a concurrency group to ensure only one workflow runs at a time:

concurrency:
  group: submodule-update
  cancel-in-progress: false

on:
  push:
    branches:
      - main
  workflow_dispatch:

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The global Git URL rewrite configuration may not be necessary and could potentially cause issues. The actions/checkout@v5 action with the token parameter should already configure Git to use HTTPS with the provided PAT. These global rewrites (lines 110-111) might interfere with that configuration. Additionally, for the git submodule update --init command to work with private repositories, you may need to ensure the submodule URL in .gitmodules uses HTTPS, or configure Git credentials explicitly. Consider testing if these lines can be removed, or add explicit credential configuration if submodule authentication fails.

Suggested change

	git config --global url."https://github.com/".insteadOf "[email protected]:"
	git config --global url."https://".insteadOf "ssh://"

[Copilot]

The COMMIT_MSG variable is retrieved twice (lines 126 and 149) from the IONOS submodule, which is redundant. Consider setting it once as an environment variable or output in the "Update IONOS submodule" step and reusing it in the "Create Pull Request" step to improve maintainability.

[Copilot]

The RELEASE_URL is constructed twice (lines 130 and 152) with identical logic. This duplication should be avoided. Consider constructing it once in the "Update IONOS submodule" step and exporting it as an environment variable or job output for reuse in the "Create Pull Request" step.

[Copilot]

The BRANCH_NAME is constructed twice (lines 114 and 145) with identical logic. This duplication should be avoided. Since it's used across different steps in the same job, consider setting it as an environment variable at the job level or export it from the first step for consistency and maintainability.