fix app config password policy #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printminion-co
force-pushed
the
mk/fix/app_config_password_policy
branch
6 times, most recently
from
496f705 to
148b2e4
Compare
Co-authored-by: printminion-co <[email protected]>
- Introduced a new target for apps that require composer installation without running scripts. - Updated build targets to include the new no-scripts category. - Enhanced output messages to reflect the new build process for composer-only apps. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Removed 'forms' and 'twofactor_totp' from the app lists, and added 'forms' to the COMPOSER_NO_SCRIPTS_APPS for improved build handling. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
- Introduced a new target `validate_app_list_uniqueness` to ensure apps are only listed in one category without duplication. - Updated help text for validation targets in the Makefile. - Integrated the new validation into the existing `validate_all` target. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/fix/app_config_password_policy
branch
from
148b2e4 to
300b916
Compare
6 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the app configuration for apps with password policy issues by introducing a new COMPOSER_NO_SCRIPTS_APPS category. The change addresses build failures where apps use @composer bin commands in their post-install scripts but have the bamarni/composer-bin-plugin only in require-dev, causing failures when running composer install --no-dev.
Key Changes:
- Introduced
COMPOSER_NO_SCRIPTS_APPScategory for apps requiring the--no-scriptsflag during composer installation - Moved
forms,password_policy, andtwofactor_totpfromFULL_BUILD_APPSto the new category - Refactored validation logic from inline bash in Makefile to standalone scripts for maintainability
- Added uniqueness validation to prevent apps from being in multiple lists
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scripts/validate_external_apps.sh | New standalone script that validates external app configuration and suggests proper categorization |
| scripts/validate_app_list_uniqueness.sh | New standalone script that validates apps appear in only one list and checks for hardcoded target conflicts |
| Makefile | Added COMPOSER_NO_SCRIPTS_APPS category, moved problematic apps, refactored validation to use external scripts, and added jq precheck |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… logic into standalone script. - Added `validate_external_apps.sh` to validate external apps and suggest proper categorization based on their configuration. - Updated Makefile to call the new validation scripts for improved app management. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/fix/app_config_password_policy
branch
from
6cd1c45 to
09f52c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.