Add jq availability check to .precheck target #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an entry to the .gitignore file to permit the inclusion of local development configuration files, enhancing the flexibility for developers working in local environments. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
This commit introduces a new target to generate an external apps matrix in JSON format, enhancing the build process by providing a structured output of app configuration details. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…stderr Ensure that the message indicating the generation of the external apps matrix YAML file is sent to standard error for better visibility during execution. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
This change modifies the Makefile to sort the list of configured apps alphabetically before iterating through them. This ensures a consistent order when processing the apps. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
- Introduced SPECIAL_BUILD_APPS variable to define apps with custom build logic. - Updated build targets to include special build targets in the build_all_external_apps target. - Adjusted app validation and configuration checks to account for special build apps. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Added a .precheck target to ensure required directories and files exist before executing build tasks. This improves error handling and user guidance when the Makefile is run from an incorrect directory. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Merged
Co-authored-by: printminion-co <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on build matrix check implementation
Add jq availability check to .precheck target
Nov 11, 2025
printminion-co
changed the base branch from
mk/dev/add_build_matrix_check
to
mk/fix/app_config_password_policy
printminion-co
force-pushed
the
mk/fix/app_config_password_policy
branch
3 times, most recently
from
148b2e4 to
300b916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generate_external_apps_matrix_jsontarget usesjqfor JSON processing but had no validation thatjqis installed, leading to cryptic failures.Changes
.prechecktarget to validatejqavailability usingcommand -v jq.precheckfor consistencyExample
When
jqis missing:All targets depending on
.precheck(includinggenerate_external_apps_matrix_json) now validatejqbefore execution.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.