ionosmail on retry config #21

printminion-co · 2025-12-04T16:18:05Z

do npm run build in order to rebuld the frontend code
Refactor the IONOS mail account creation logic to improve error handling, conflict resolution, and code maintainability.
Add a dedicated command for creating IONOS accounts
Centralize conflict resolution, and enhances the controller and DTOs to support these workflows. The changes also update dependencies and improve error reporting.

Backport after merge add unit tests for SetupService nextcloud/mail#12141

Tests

do npm run build in order to rebuld the frontend code
disable certificate check (for local testing)

./occ config:app:set --value true --type boolean -- mail ionos_mailconfig_api_allow_insecure

check mail accounts configured for user g1user2 in nextcloud.
- Observe: no IONOS mail accounts configured.

./occ mail:account:export g1user1

create IONOS mail via web UI
Delete mail account.
- Observe: Nextcloud mail config is removed. IONOS mail config is removed.

./occ mail:account:delete $ACCOUNT_ID

Known issues

If ionos IMAP server is not up yet. Account will be created on IONOS and NC side but redirect into Mail iterface is not happening due to connection test on Nextcloud side (probably we can refactor it)

Copilot

Pull request overview

This pull request implements retry logic for IONOS mail account creation when API failures occur. When account creation initially fails, the system now attempts to resolve conflicts by checking if an IONOS account already exists for the user, and if so, retrieves a fresh password to retry the Nextcloud account creation process.

Key Changes:

Added conflict resolution mechanism to handle cases where IONOS API account exists but Nextcloud account creation failed
Implemented password reset functionality to retrieve new credentials for existing IONOS accounts
Added CLI command for creating IONOS accounts outside of web requests
Introduced skip connectivity test option to allow account creation when IONOS has already validated credentials

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`lib/Service/IONOS/IonosAccountConflictResolver.php`	New service to resolve conflicts when account creation fails by checking for existing accounts
`lib/Service/IONOS/ConflictResolutionResult.php`	DTO representing the result of conflict resolution with retry capability
`lib/Service/IONOS/IonosMailService.php`	Added methods to get existing account config, reset app passwords, and create accounts for specific users
`lib/Service/IONOS/Dto/MailAccountConfig.php`	Added `withPassword()` method to create new config instances with updated passwords
`lib/Service/IONOS/Dto/MailServerConfig.php`	Added `withPassword()` method to create new config instances with updated passwords
`lib/Controller/IonosAccountsController.php`	Integrated conflict resolver to retry account creation when initial attempt fails
`lib/Controller/AccountsController.php`	Added `skipConnectivityTest` parameter to bypass connection testing
`lib/Service/SetupService.php`	Added `skipConnectivityTest` parameter to allow account creation without connectivity validation
`lib/Command/IonosCreateAccount.php`	New CLI command for creating IONOS accounts via OCC
`tests/Unit/Service/IONOS/IonosMailServiceTest.php`	Comprehensive test coverage for new mail service methods
`tests/Unit/Service/IONOS/IonosAccountConflictResolverTest.php`	Test coverage for conflict resolution logic
`tests/Unit/Controller/IonosAccountsControllerTest.php`	Test coverage for retry scenarios in controller
`tests/Unit/Service/SetupServiceTest.php`	New test file for SetupService functionality
`tests/Unit/Command/IonosCreateAccountTest.php`	Test coverage for CLI command
`composer.json`	Updated IONOS API client reference
`appinfo/info.xml`	Registered new CLI command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lib/Service/IONOS/IonosMailService.php

…251208083401 composer update ionos-productivity/ionos-mail-configuration-api-client https://github.com/IONOS-Productivity/ionos-mail-configuration-api-client/releases/tag/2.0.0-20251208083401 Signed-off-by: Misha M.-Kupriyanov <[email protected]>

Added comprehensive unit tests for the SetupService class, covering account creation with various authentication methods, handling of connectivity tests, and validation of authentication methods. This enhances test coverage and ensures the reliability of the account setup functionality. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

…o createNewAccount Add optional parameter to allow skipping IMAP/SMTP connectivity tests during account creation. This is useful when account credentials are already validated by external systems or when immediate connectivity cannot be guaranteed due to DNS propagation delays. The parameter defaults to false to maintain backward compatibility. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

…eter to create method Add optional parameter to AccountsController::create() to allow skipping IMAP/SMTP connectivity tests during account creation. This parameter is passed through to SetupService::createNewAccount(). This enables external systems (e.g., IONOS API) that have already validated credentials to skip redundant connectivity tests, particularly useful when DNS propagation delays might cause immediate connectivity tests to fail. The parameter defaults to false to maintain backward compatibility.

… data and improved mock setups Refactor test methods to utilize constants for user and email details, ensuring consistency and readability. This change improves maintainability and reduces duplication across test cases. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

…nt for specific user This change introduces a new method to create an IONOS email account for a specified user, allowing for account creation without relying on the user session. This is particularly useful for OCC commands or administrative operations. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

Copilot

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-16T17:08:13Z

lib/Service/IONOS/IonosMailService.php

 				throw new ServiceException('Failed to create ionos mail', $result->getStatus());
 			}
-			if ($result instanceof MailAccountResponse) {
+			if ($result instanceof MailAccountCreatedResponse) {


The comment on line 318 states this method handles MailAccountCreatedResponse from createFunctionalAccount, but the actual API call on line 168 uses createMailbox, not createFunctionalAccount. Update the comment to accurately reflect the API method being called.

lib/Command/IonosCreateAccount.php

Copilot

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-17T11:41:59Z

tests/Unit/Service/IONOS/IonosMailServiceTest.php

 use GuzzleHttp\ClientInterface;
 use IONOS\MailConfigurationAPI\Client\Api\MailConfigurationAPIApi;
 use IONOS\MailConfigurationAPI\Client\Model\Imap;
+use IONOS\MailConfigurationAPI\Client\Model\MailAccountCreatedResponse;


The import for MailAccountCreatedResponse is added, but verify that test coverage exists for all methods that use this type versus MailAccountResponse. Ensure there are tests verifying the distinction between these response types in account creation vs retrieval scenarios.

Copilot · 2025-12-17T11:42:00Z

lib/Service/IONOS/IonosAccountConflictResolver.php

+
+			// Get fresh password via resetAppPassword API since getAccountConfigForUser
+			// does not return password for security reasons
+			$newPassword = $this->ionosMailService->resetAppPassword($userId, IonosConfigService::APP_NAME);


Add a comment explaining that resetAppPassword generates a new app-specific password from the IONOS API, as this is a critical security operation and the behavior may not be immediately obvious from the method name alone.

lib/Command/IonosCreateAccount.php

tests/Unit/Service/IONOS/IonosAccountCreationServiceTest.php

…anced error handling Introduce IonosServiceException to provide a structured way to handle exceptions related to IONOS services, including additional data storage for context. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

Add unified service for creating and updating IONOS mail accounts: - Check for existing Nextcloud accounts before creation - Handle conflict resolution with existing IONOS accounts - Create new accounts with encrypted credentials - Update existing accounts with fresh credentials This service provides consistent account creation logic for both CLI and web interfaces, with proper retry handling for DNS propagation delays. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

…availability check Update isMailConfigAvailable to check for local account configuration: - Add AccountService and IUserSession dependencies - Check if user has remote IONOS account - Check if remote account is configured locally in mail app - Show configuration if remote exists but local doesn't (retry scenario) This allows users to complete account setup if the initial Nextcloud account creation failed but the IONOS account was created. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

…ogging in IonosAccountsController Enhanced error handling by introducing a dedicated method for building service error responses. Improved logging messages for better clarity during account creation process. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

…count creation Enhances the IonosAccountsController by integrating user session management, allowing for user identification during email account creation. This improves error handling by ensuring that a valid user session is present, providing more informative logging and responses in case of session absence. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

…ice in IonosAccountsController Refactor IonosAccountsController to use the shared IonosAccountCreationService: - Replace IonosMailService and AccountsController with IonosAccountCreationService - Add IUserSession for user ID retrieval - Simplify create method by delegating to IonosAccountCreationService - Add error message to service exception responses This ensures consistent account creation logic between web and CLI interfaces. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

Copilot

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-17T13:30:43Z

lib/Service/IONOS/IonosMailService.php

 use IONOS\MailConfigurationAPI\Client\ApiException;
+use IONOS\MailConfigurationAPI\Client\Model\Imap;
+use IONOS\MailConfigurationAPI\Client\Model\MailAccountCreatedResponse;
 use IONOS\MailConfigurationAPI\Client\Model\MailAccountResponse;


The import for MailAccountResponse at line 16 appears to be used only in private methods that handle existing accounts. Consider documenting in these methods that MailAccountResponse is the type returned by getFunctionalAccount (for existing accounts) while MailAccountCreatedResponse is returned by createFunctionalAccount (for new accounts) to clarify the distinction between these similar types.

src/components/ionos/NewEmailAddressTab.vue

… existing email address conflict Updated the feedback message for the 409 error code to provide clearer guidance on existing IONOS email addresses, including the conflicting email address. Signed-off-by: Misha M.-Kupriyanov <[email protected]>

Copilot

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

printminion-co marked this pull request as draft December 4, 2025 16:18

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch 18 times, most recently from e38c671 to 79c50cf Compare December 8, 2025 13:16

printminion-co requested a review from Copilot December 8, 2025 13:27

Copilot AI reviewed Dec 8, 2025

View reviewed changes

lib/Service/IONOS/IonosMailService.php Show resolved Hide resolved

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch from 79c50cf to 7c42154 Compare December 8, 2025 14:02

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch from 7c42154 to 6d36dee Compare December 9, 2025 14:22

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch from 6d36dee to 7219b90 Compare December 10, 2025 13:55

printminion-co added 4 commits December 10, 2025 15:46

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch from b242311 to fb86530 Compare December 16, 2025 17:06

printminion-co requested a review from Copilot December 16, 2025 17:06

Copilot AI reviewed Dec 16, 2025

View reviewed changes

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch 2 times, most recently from 1b7629d to 955ec81 Compare December 17, 2025 11:40

printminion-co requested a review from Copilot December 17, 2025 11:41

Copilot AI reviewed Dec 17, 2025

View reviewed changes

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch from 955ec81 to 10abdfd Compare December 17, 2025 12:47

printminion-co added 6 commits December 17, 2025 14:11

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch from 10abdfd to 41309ff Compare December 17, 2025 13:27

printminion-co requested a review from Copilot December 17, 2025 13:28

Copilot AI reviewed Dec 17, 2025

View reviewed changes

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch 2 times, most recently from 09628c7 to 9e436c2 Compare December 17, 2025 13:45

printminion-co marked this pull request as ready for review December 18, 2025 10:46

printminion-co mentioned this pull request Dec 18, 2025

ionosmail get app password + External Mail Account Provider System Implementation #25

Open

printminion-co marked this pull request as draft December 19, 2025 13:57

printminion-co marked this pull request as ready for review December 22, 2025 13:54

printminion-co force-pushed the mk/dev/ionosmail-on-retry-config branch from 9e436c2 to d4022b9 Compare December 22, 2025 13:55

Arsalanulhaq requested a review from Copilot December 24, 2025 09:56

Copilot AI reviewed Dec 24, 2025

View reviewed changes

Arsalanulhaq approved these changes Dec 29, 2025

View reviewed changes

printminion-co merged commit 3771be4 into ionos-dev Dec 29, 2025
34 of 67 checks passed

printminion-co deleted the mk/dev/ionosmail-on-retry-config branch December 29, 2025 09:55

ionosmail on retry config #21

ionosmail on retry config #21

Uh oh!

Conversation

printminion-co commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests

Known issues

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes:

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

printminion-co commented Dec 4, 2025 •

edited

Loading