Refactor commit 195c82c1 into atomic commits with logical separation of concerns #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…251208083401 composer update ionos-productivity/ionos-mail-configuration-api-client https://github.com/IONOS-Productivity/ionos-mail-configuration-api-client/releases/tag/2.0.0-20251208083401 Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Added comprehensive unit tests for the SetupService class, covering account creation with various authentication methods, handling of connectivity tests, and validation of authentication methods. This enhances test coverage and ensures the reliability of the account setup functionality. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…o createNewAccount Add optional parameter to allow skipping IMAP/SMTP connectivity tests during account creation. This is useful when account credentials are already validated by external systems or when immediate connectivity cannot be guaranteed due to DNS propagation delays. The parameter defaults to false to maintain backward compatibility. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…eter to create method Add optional parameter to AccountsController::create() to allow skipping IMAP/SMTP connectivity tests during account creation. This parameter is passed through to SetupService::createNewAccount(). This enables external systems (e.g., IONOS API) that have already validated credentials to skip redundant connectivity tests, particularly useful when DNS propagation delays might cause immediate connectivity tests to fail. The parameter defaults to false to maintain backward compatibility.
… data and improved mock setups Refactor test methods to utilize constants for user and email details, ensuring consistency and readability. This change improves maintainability and reduces duplication across test cases. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…nt for specific user This change introduces a new method to create an IONOS email account for a specified user, allowing for account creation without relying on the user session. This is particularly useful for OCC commands or administrative operations. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…connectivity test for IONOS accounts - Add getAccountConfigForCurrentUser method to retrieve existing IONOS account config - Update IonosAccountsController to retry with existing config if account already exists - Pass skipConnectivityTest=true to AccountsController for IONOS accounts - This resolves the issue where DNS propagation delays cause account creation to fail The retry scenario handles cases where: 1. IONOS account created successfully via API 2. Nextcloud account creation failed due to DNS not propagated 3. User retries - IONOS account already exists 4. System retrieves existing config and creates Nextcloud account Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…il accounts Introduce a new command for creating and configuring IONOS mail accounts in Nextcloud, enhancing user account management capabilities. php occ mail:ionos:create <user-id> <email-user> --name="Account Name" Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Copilot
AI
changed the title
[WIP] Refactor ionosmail on retry configuration
Refactor commit 195c82c1 into atomic commits with logical separation of concerns
Dec 16, 2025
|
@copilot I see no mk/dev/ionosmail-on-retry-config-refactored-v2 branch in my repo |
Author
The refactored commits are on branch
You can check it with: git fetch origin mk/dev/ionosmail-on-retry-config-refactored
git log origin/mk/dev/ionosmail-on-retry-config-refactored |
printminion-co
force-pushed
the
mk/dev/ionosmail-on-retry-config
branch
11 times, most recently
from
9e436c2 to
d4022b9
Compare
Base automatically changed from
mk/dev/ionosmail-on-retry-config
to
ionos-dev
December 29, 2025 09:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Plan for commit 195c82c
Summary
Successfully split the large commit 195c82c into 8 atomic, logical commits on branch
copilot/refactor-ionic-mail-retry-config:Each commit is:
The refactored commits have identical end state to original commit 195c82c.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.