fix(templates/listItem): add second template literal #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the email list item template where the second template literal placeholder was missing, causing the template to render two icons instead of an icon and text. The fix replaces a hardcoded image tag with a %s placeholder that will be populated with the appropriate content at runtime.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
Arsalanulhaq
approved these changes
Dec 4, 2025
There are two template literals 1. Icon 2. Text As the second one was missing we had two icons and no text in those list items Signed-off-by: Kai Henseler <[email protected]>
bromiesTM
force-pushed
the
kh/dev/fix-broken-mails
branch
from
9a51c4b to
c404ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two template literals
As the second one was missing we had two icons and no text in those list items