add build matrix check #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printminion-co
force-pushed
the
mk/dev/add_build_matrix_check
branch
from
95b939a to
f19d18d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds automated validation to ensure the GitHub Actions workflow matrix stays in sync with the Makefile configuration. The workflow matrix has been alphabetically reordered and updated to match the Makefile's source of truth.
Key Changes:
- Added a validation step that compares the workflow matrix against the Makefile-generated matrix
- Reordered and updated the build matrix entries alphabetically
- Updated the IONOS submodule reference
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| IONOS | Updated submodule commit reference |
| .github/workflows/build-artifact.yml | Added repository checkout, dependency installation, and comprehensive matrix validation logic; reordered matrix entries alphabetically and updated ncw_mailtemplate's has_npm flag |
seriAlizations
approved these changes
Nov 11, 2025
seriAlizations
left a comment
seriAlizations
left a comment
There was a problem hiding this comment.
lgtm, might consider implementing the suggested copilot change about the fetch depth.
…target for validation before builds) https://github.com/IONOS-Productivity/ncw-config/releases/tag/945436e Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yq '.jobs.prepare-matrix.steps[].run' .github/workflows/build-artifact.yml | sed -n "/matrix='/,/'$/p" | sed "s/.*matrix='//;s/'$//" | jq '.' > matrix.original.json jq 'sort_by(.name)' matrix.original.json > matrix.sorted.json Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
for compatibility reasons Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
… workflow Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
mk/dev/add_build_matrix_check
branch
from
628f352 to
d8fefac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Checklist