forked from nextcloud/server
-
Notifications
You must be signed in to change notification settings - Fork 0
Optimize restore-cached-apps job to eliminate unnecessary parallel runners #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
16
commits into
ionos-donot-merge
Choose a base branch
from
copilot/sub-pr-127
base: ionos-donot-merge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
for later performance comparison Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order not to overwrite optimized artifact Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…pace artifact Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…ompatibility Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…tion Signed-off-by: Misha M.-Kupriyanov <[email protected]>
30 tasks
Co-authored-by: printminion-co <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on avoiding rebuilds for apps
Optimize restore-cached-apps job to eliminate unnecessary parallel runners
Nov 12, 2025
09c736f to
f784d18
Compare
bfd419e to
6afffe5
Compare
6afffe5 to
80e40e2
Compare
Base automatically changed from
mk/poc/dont_rebuild_already_built_apps
to
ionos-donot-merge
December 2, 2025 13:26
26557aa to
48f3905
Compare
1a618a9 to
71ecc37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
restore-cached-appsjob spawned runners for ALL apps in the matrix, then each runner checked if it should skip. If 25/27 apps were cached, this meant 27 parallel runners where 25 immediately skipped—wasteful.Changes
Matrix filtering in
prepare-matrixjob:apps-to-restoreoutput containing only cached apps (inverse ofapps-to-build)apps-to-buildlistSimplified
restore-cached-appsjob:apps-to-restoreinstead of fullexternal-apps-matrixCheck if app needs restoring from cachestep entirelyif: steps.check-cache.outputs.skip == 'false'conditionshas-cached-apps == 'true'toapps-to-restore != '[]'Result: If 25 apps are cached, exactly 25 runners spawn (not 27).
TODO
N/A
Checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.