Skip to content

Conversation

Copy link

Copilot AI commented Nov 12, 2025

Summary

The restore-cached-apps job spawned runners for ALL apps in the matrix, then each runner checked if it should skip. If 25/27 apps were cached, this meant 27 parallel runners where 25 immediately skipped—wasteful.

Changes

Matrix filtering in prepare-matrix job:

  • Added apps-to-restore output containing only cached apps (inverse of apps-to-build)
  • Built during cache detection step alongside apps-to-build list

Simplified restore-cached-apps job:

  • Matrix now uses filtered apps-to-restore instead of full external-apps-matrix
  • Removed Check if app needs restoring from cache step entirely
  • Removed all if: steps.check-cache.outputs.skip == 'false' conditions
  • Changed job condition from has-cached-apps == 'true' to apps-to-restore != '[]'

Result: If 25 apps are cached, exactly 25 runners spawn (not 27).

# Before: spawned 27 runners, 25 skipped immediately
matrix:
  app: ${{ fromJson(needs.prepare-matrix.outputs.external-apps-matrix) }}

# After: spawns only runners for cached apps
matrix:
  app_info: ${{ fromJson(needs.prepare-matrix.outputs.apps-to-restore) }}

TODO

N/A

Checklist


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

bromiesTM and others added 15 commits November 12, 2025 12:43
for later performance comparison

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order not to overwrite optimized artifact

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Copilot AI changed the title [WIP] Address feedback on avoiding rebuilds for apps Optimize restore-cached-apps job to eliminate unnecessary parallel runners Nov 12, 2025
Copilot AI requested a review from printminion-co November 12, 2025 14:07
@printminion-co printminion-co force-pushed the mk/poc/dont_rebuild_already_built_apps branch 7 times, most recently from 09c736f to f784d18 Compare November 13, 2025 12:28
@printminion-co printminion-co force-pushed the mk/poc/dont_rebuild_already_built_apps branch 3 times, most recently from bfd419e to 6afffe5 Compare November 13, 2025 14:25
@printminion-co printminion-co force-pushed the mk/poc/dont_rebuild_already_built_apps branch from 6afffe5 to 80e40e2 Compare December 2, 2025 12:38
Base automatically changed from mk/poc/dont_rebuild_already_built_apps to ionos-donot-merge December 2, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants