IONOS(navigation): remove developer documentation link from AppStoreN… #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
yq '.jobs.prepare-matrix.steps[].run' .github/workflows/build-artifact.yml | sed -n "/matrix='/,/'$/p" | sed "s/.*matrix='//;s/'$//" | jq '.' > matrix.original.json jq 'sort_by(.name)' matrix.original.json > matrix.sorted.json Signed-off-by: Misha M.-Kupriyanov <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the AppStore navigation to conditionally display the developer documentation link based on a configuration value. The change allows IONOS customizations to hide the developer documentation link when not needed.
Key changes:
- Added conditional rendering of the developer documentation link in the AppStore navigation
- Introduced a new configuration variable
devDocsUrlto control the visibility of the documentation link
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/settings/src/views/AppStoreNavigation.vue | Added v-if="devDocsUrl" condition to the developer documentation navigation item and loaded the new configuration variable |
| apps/settings/lib/Controller/AppSettingsController.php | Added initial state provision for devDocsUrl from theming app configuration |
…avigation Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Arsalanulhaq
force-pushed
the
as/dev/dev_docs_url
branch
from
fc2adde to
52eddb5
Compare
Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
bromiesTM
force-pushed
the
ionos-donot-merge
branch
from
413bc91 to
4ceb9f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Checklist