IONOS(config): add empty url for devDocsUrl in theming config #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arsalanulhaq
force-pushed
the
as/dev/dev_docs_url
branch
from
8329ee6 to
af60857
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for conditionally showing the developer documentation link in the app store navigation based on a configurable URL. The change allows IONOS theming configuration to control whether the developer docs link appears by setting or leaving empty the devDocsUrl configuration value.
Key Changes
- Added conditional rendering of the developer documentation link based on a new
devDocsUrlconfiguration value - Introduced new initial state loading for
devDocsUrlfrom theming configuration - Updated IONOS submodule to include the corresponding theming configuration changes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/settings/src/views/AppStoreNavigation.vue | Added conditional rendering (v-if="devDocsUrl") to show/hide developer docs link and loaded new devDocsUrl state |
| apps/settings/lib/Controller/AppSettingsController.php | Added initial state provider for devDocsUrl from theming app configuration |
| IONOS | Updated submodule commit to include theming configuration changes |
Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Arsalanulhaq
force-pushed
the
as/dev/dev_docs_url
branch
from
af60857 to
994e23e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Checklist