NCW-1 live release #146
Merged
NCW-1 live release #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow): improve conditional check for submodule PR creation) https://github.com/IONOS-Productivity/ncw-config/releases/tag/6c76022 Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Signed-off-by: Aliza Held <[email protected]>
This reverts commit 4d1c3e1. Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
…oidc app) Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
…target for validation before builds) https://github.com/IONOS-Productivity/ncw-config/releases/tag/945436e Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yq '.jobs.prepare-matrix.steps[].run' .github/workflows/build-artifact.yml | sed -n "/matrix='/,/'$/p" | sed "s/.*matrix='//;s/'$//" | jq '.' > matrix.original.json jq 'sort_by(.name)' matrix.original.json > matrix.sorted.json Signed-off-by: Misha M.-Kupriyanov <[email protected]>
for compatibility reasons Signed-off-by: Misha M.-Kupriyanov <[email protected]>
… workflow Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…ed your Makefile to separate complex bash logic into standalone script.) https://github.com/IONOS-Productivity/ncw-config/releases/tag/3dc76d7 Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
…or apps requiring composer with --no-scripts and npm build) https://github.com/IONOS-Productivity/ncw-config/releases/tag/c18550d Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces several updates to the workflow configuration and repository structure, focusing on improving the build process for external apps and enhancing validation and error reporting. The main changes include updating the external apps matrix in the GitHub Actions workflow, adding a new app submodule, synchronizing submodules, and improving error handling in the LDAP user mapping logic.
Workflow and Build Process Improvements
.github/workflows/build-artifact.ymlto reflect new, reordered, and updated app entries, ensuring alignment with the current set of external apps and their build requirements. This includes changes to app names, paths, and build targets, as well as correcting thehas_npmproperty for some apps. [1] [2] [3] [4] [5] [6] [7]makeandjq) at the beginning of the workflow to support matrix generation and validation.Repository and Submodule Management
user_oidcapp as a new submodule and updated.gitmodulesand related files to include it. [1] [2]IONOSandmailto point to their latest versions. [1] [2]LDAP User Mapping Robustness
dn2ocnamefunction inapps/user_ldap/lib/Access.phpby catchingHintException(such as user limit reached), logging a warning, and returningfalseto prevent mapping failures from causing unhandled exceptions.TODO
Checklist