Skip to content

Conversation

@Arsalanulhaq
Copy link

@Arsalanulhaq Arsalanulhaq commented Dec 11, 2025

TODO

Checklist

@Arsalanulhaq Arsalanulhaq changed the title As/feat/hide developer docs conditionally feat(theming): hide developer docs conditionally Dec 11, 2025
@Arsalanulhaq Arsalanulhaq force-pushed the as/feat/hide-developer-docs-conditionally branch from b49187e to b5f402f Compare December 11, 2025 09:06
@Arsalanulhaq Arsalanulhaq requested a review from Copilot December 11, 2025 14:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to conditionally hide the developer documentation link in the app store navigation based on a configuration setting. The feature respects a new display_documentation_link configuration option in the settings app config, which defaults to true to maintain backward compatibility.

Key changes:

  • Added configuration check to control developer documentation link visibility
  • Updated frontend to conditionally render the link based on the configuration
  • Added comprehensive test coverage for the new behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/settings/lib/Controller/AppSettingsController.php Added IAppConfig dependency and conditional logic to set developer docs URL based on configuration
apps/settings/src/views/AppStoreNavigation.vue Added v-if directive to conditionally render developer docs navigation item
apps/settings/tests/Controller/AppSettingsControllerTest.php Added IAppConfig mock and three new test methods to verify the conditional behavior

Comment on lines +307 to +309
->willReturnCallback(function ($key, $value) use (&$providedStates) {
$providedStates[$key] = $value;
});
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same callback pattern is duplicated in multiple test methods (lines 307-309, 351-353, 208-212, 258-262). Consider extracting this into a helper method to reduce duplication and improve maintainability.

Copilot uses AI. Check for mistakes.
@Arsalanulhaq Arsalanulhaq changed the title feat(theming): hide developer docs conditionally IONOS(theming): hide developer docs conditionally Dec 15, 2025
@Arsalanulhaq Arsalanulhaq changed the title IONOS(theming): hide developer docs conditionally IONOS(appsettings): hide developer docs conditionally Dec 15, 2025
@Arsalanulhaq Arsalanulhaq force-pushed the as/feat/hide-developer-docs-conditionally branch from 9014069 to ab729da Compare December 15, 2025 11:17
@Arsalanulhaq Arsalanulhaq force-pushed the as/feat/hide-developer-docs-conditionally branch from ab729da to 76ffaae Compare December 15, 2025 11:42
@Arsalanulhaq Arsalanulhaq merged commit 6aa0e53 into ionos-donot-merge Dec 15, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants