nsw-2 #170
Merged
nsw-2 #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
…ionos email account Signed-off-by: Aliza Held <[email protected]> Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
yq '.jobs.prepare-matrix.steps[].run' .github/workflows/build-artifact.yml | sed -n "/matrix='/,/'$/p" | sed "s/.*matrix='//;s/'$//" | jq '.' > matrix.original.json jq 'sort_by(.name)' matrix.original.json > matrix.sorted.json Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
…or css file content loading Signed-off-by: Aliza Held <[email protected]> Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
…core config Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
…y-c9 Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
… consistency Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
for later performance comparison Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order not to overwrite optimized artifact Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…ompatibility Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
lets use underscore Signed-off-by: Misha M.-Kupriyanov <[email protected]>
drop validation since it is now Redundant (by design) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Optimized build workflow that uses cache-based detection - Checks cache for each app's current SHA - Only builds apps with no cached build - Significantly reduces build time through smart caching Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…fact.yml Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Implement intelligent cache detection for Nextcloud apps in the build artifact workflow. This enhancement improves build performance by detecting which apps need rebuilding based on git changes. Key features: - Detect changed apps using git diff against base branch - Add verbose logging for debugging cache behavior - Optimize performance with parallel cache operations - Remove strict PR requirement to enable testing flexibility Signed-off-by: Kai Henseler <[email protected]>
Extract cache detection logic from workflow YAML into a dedicated script file for better maintainability and testability. Changes: - Create `.github/scripts/detect-app-cache.sh` with all detection logic - Simplify workflow file by calling the external script - Improve code readability and separation of concerns - Enable easier testing and iteration of cache detection logic Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
partial revert of 647f4c4 Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
…lity in sharing dropdown Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
…admin selection Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
in order to fail of jfrog is not accessible Signed-off-by: Misha M.-Kupriyanov <[email protected]>
force override vue button style of:
.button-vue[data-v-37a61812]:hover {
background-color: var(--color-background-hover) !important;
}
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces several improvements and bug fixes across the codebase. The most significant changes are the addition of a robust app cache detection script for CI, enhancements to group management in the user creation dialog, a new configuration option to conditionally display the developer documentation link in the App Store navigation, and stricter validation for comment access in the DAV comments API. Additionally, several submodules have been updated.
App Cache Detection and CI Improvements
.github/scripts/detect-app-cache.sh, a comprehensive script that determines which apps need rebuilding and which can be restored from cache, supporting both GitHub Actions cache and JFrog Artifactory as sources. The script outputs JSON for downstream CI steps and provides detailed reporting and validation.App Store Navigation and Developer Docs Link
settings:display_documentation_link) to control the visibility of the developer documentation link in the App Store navigation. The backend (AppSettingsController.php) and frontend (AppStoreNavigation.vue) were updated to respect this setting, and related tests were added and updated. [1] [2] [3] [4] [5] [6] [7] [8] [9]User Group Management Enhancements
NewUserDialog.vuecomponent to allow removing groups from the new user's group list via the UI, adding aremoveGroupmethod and handling theoption:deselectedevent. [1] [2]DAV Comments API Hardening
EntityCollectionclass in the DAV comments API to ensure that only comments belonging to the correct object type and ID can be accessed, preventing cross-object access. Corresponding unit tests were updated to cover these cases. [1] [2] [3] [4]Submodule Updates
IONOS,mail,ncw_apps_menu, andncw_mailtemplateto newer commits. [1] [2] [3] [4]TODO
Checklist