IONOS(theming): fix secondary button background color hover state #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printminion-co
force-pushed
the
mk/dev/fix_dashboard_secondary_buttons_bg-color
branch
from
7fb60f0 to
344e4f1
Compare
Arsalanulhaq
reviewed
Jan 5, 2026
apps/theming/css/ionos/buttons.css
Outdated
| &.button-vue--vue-primary:not(.unified-search-modal__header *), &.button-vue--vue-error:not(.unified-search-modal__header *), | ||
| /* ensure primary type styling of "new" button */ | ||
| &.action-item__menutoggle:not(.unified-search-modal__header *), &.files-list__header-upload-button--disabled { | ||
| background-color: var(--ion-button-primary-background-default); |
There was a problem hiding this comment.
Suggested change
| background-color: var(--ion-button-primary-background-default) !important; |
this also needs to be set. Because it obfuscates the view of active tab on dashboard buttons
printminion-co
force-pushed
the
mk/dev/fix_dashboard_secondary_buttons_bg-color
branch
from
344e4f1 to
a3fe751
Compare
force override vue button style of:
.button-vue[data-v-37a61812]:hover {
background-color: var(--color-background-hover) !important;
}
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/fix_dashboard_secondary_buttons_bg-color
branch
from
a3fe751 to
3b808ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes a minor update to the button styling in the
apps/theming/css/ionos/buttons.cssfile. The change enforces the use of the hover background color by adding!importantto thebackground-colorproperty for secondary buttons.!importantto thebackground-colorproperty for secondary button hover state to ensure the correct style is applied.force override vue button style of:
TODO
Checklist