-
Notifications
You must be signed in to change notification settings - Fork 0
Add App Tables #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add App Tables #53
Conversation
https://github.com/nextcloud/tables/releases/tag/v0.9.5 git submodule add -f [email protected]:nextcloud/tables.git apps-external/tables cd apps-external/tables git checkout v0.9.5 git submodule update --init apps-external/tables git add .gitmodules apps-external/tables
Signed-off-by: Aliza Held <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the Nextcloud Tables app as a submodule to the project and configures the build system to include it in the build process.
- Adds the tables app as a Git submodule pointing to the official nextcloud/tables repository
- Updates the GitHub Actions workflow to build the tables app with npm and composer support
- Updates the IONOS submodule to a newer commit
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps-external/tables | Adds the tables app as a new submodule |
| .gitmodules | Registers the tables submodule configuration |
| .github/workflows/build-artifact.yml | Adds build configuration for the tables app |
| IONOS | Updates the IONOS submodule commit reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Aliza Held <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Added tables app to build matrix in workflow - Added tables submodule to .gitmodules - Updated IONOS submodule with tables app build configuration - Resolved conflicts by keeping both existing and new external apps
93c30cd to
cb52017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Aliza Held <[email protected]>
0177cbb to
b2516c2
Compare
Summary
TODO
Checklist