Skip to content

Conversation

@bromiesTM
Copy link

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the IONOS theme implementation by extracting inline CSS into separate organized CSS files and adding custom font support. The main changes improve code maintainability by separating concerns and enhance the theme with OpenSans font integration.

  • Extracts hardcoded CSS from PHP into separate CSS files organized by functionality (variables, sidebar, files, layout)
  • Adds OpenSans font support with multiple font weights and formats
  • Updates font-face configuration and CSS variable definitions

Reviewed Changes

Copilot reviewed 5 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
apps/theming/lib/Themes/IonosTheme.php Refactored to load CSS from external files and added OpenSans font integration
apps/theming/css/ionos/variables.css New file containing CSS custom properties for IONOS theme styling
apps/theming/css/ionos/sidebar.css New file containing sidebar-specific styling rules
apps/theming/css/ionos/files.css New file containing file list and dialog styling rules
apps/theming/css/ionos/_layout.css New file containing header and layout styling rules

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@printminion-co printminion-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add "IONOS" as commit prefix

lets do some refactorings #8

@tanyaka
Copy link

tanyaka commented Aug 20, 2025

Applied the feedback and adapted the refacroring of #8 in #10

@tanyaka
Copy link

tanyaka commented Aug 20, 2025

Closed in favor of #10

@tanyaka tanyaka closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants