Skip to content

Conversation

@bkatiemills
Copy link
Member

This PR will contain a script to add a column to AutoQC's sql database that indicate per-level IQuOD QC flags for the profiles analyzed. This script is meant to run as a standalone post-processing step, similar to summarize_results.py.

@bkatiemills
Copy link
Member Author

To be resolved before merge:

  • @s-good, I assume "CS XBT surf. temp." referred to in the paper corresponds to the QC testCSIRO_depth; let me know if this is wrong.
  • Speaking of CSIRO_depth, including this saddles many profiles in quota_subset with flag 3 for every level, since we're propagating XBT flags downwards. Is this really what we want, or in this case is just the surface measurement bad?
  • Todo: still need to actually write the result back to the database
  • Todo: need a better validation sample to make sure I'm getting what we expect. @BoyerWOD if you have or can generate some wodascii with correct IQuOD flags we can test against, that would be helpful.

@s-good
Copy link
Contributor

s-good commented Feb 10, 2023

Sorry for the delay in replying to this.

  • Yes, CS XBT surf. temp. is CSIRO_depth.
  • CSIRO_depth should not be propogated downwards. The same is true for ICDC_aqc_01_level_order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants