Rename i_df and investigation_df. #529
Conversation
|
Interesting. I wouldn't have expected this one to break anything since it just renames variables/parameters. I am looking into the testing now to try and understand how it all works to try and make changes to them so some of these PRs will pass. |
|
That's strange. I don't see @terazus comments, but I got an email about it. I think you are right. I will look through the tests and try to find the renaming changes. |
The last changes were initially tested and created on Windows, but had errors on GitHub. I fixed those errors, but didn't retest on Windows. This has been tested on both and is problem free.
i_df and investigation_df are not a DataFrame as indicated in parameter typing or as the name would suggest. It's actually a dictionary of DataFrames and lists of DataFrames. I have renamed them to reflect this.
ptth222
force-pushed
the
tab-validate-idf-rename
branch
from
3a9a96c to
299a93d
Compare
|
I did not mean to trigger a rerun on this when I rebased it. I am working on looking at the broken tests now. |
There were 2 tests that needed to be changed to match the new naming.
You can mark PR as draft if you are not ready yet. |
|
@terazus It is ready now. It initially ran when I did the rebase because the PR was already here and I think it was previously approved. The last commit I made triggered another rerun, but that is good to go. |
i_df and investigation_df are not a DataFrame as indicated in parameter typing or as the name would suggest. It's actually a dictionary of DataFrames and lists of DataFrames. I have renamed them to reflect this.