sanitizing json2jsonld serialization and fixing failing tests resulti…#617
Merged
proccaserra merged 2 commits intordf-testfrom Mar 13, 2026
Merged
sanitizing json2jsonld serialization and fixing failing tests resulti…#617proccaserra merged 2 commits intordf-testfrom
proccaserra merged 2 commits intordf-testfrom
Conversation
…ng from alterations to isatools/model and isatools/database
knirirr
reviewed
Mar 9, 2026
| def test_to_dict(self, mock_uuid4): | ||
| study = Study(id_="#study/" + mock_uuid4.return_value) | ||
| assay = Assay( | ||
| # id_="#assay-/" + mock_uuid4.return_value, |
Contributor
There was a problem hiding this comment.
Suggested change
| # id_="#assay-/" + mock_uuid4.return_value, |
knirirr
reviewed
Mar 9, 2026
| technology_type=OntologyAnnotation(term="TT", id_="TT_ID"), | ||
| ) | ||
|
|
||
| print("ID:", assay.id) |
Contributor
There was a problem hiding this comment.
Suggested change
| print("ID:", assay.id) | |
| # print("ID:", assay.id) |
knirirr
reviewed
Mar 9, 2026
| # expected_dict["materials"]["samples"] = [{"@id": "my_sample"}] | ||
| indexes.samples = {"my_sample": Sample(id_="my_sample")} | ||
| assay = Assay() | ||
| # assay = Assay() |
Contributor
There was a problem hiding this comment.
Suggested change
| # assay = Assay() |
knirirr
reviewed
Mar 9, 2026
| {"@id": "my_data_file", "name": "filename", "type": "RawDataFile", "comments": []} | ||
| ] | ||
| assay = Assay() | ||
| # assay = Assay() |
Contributor
There was a problem hiding this comment.
Suggested change
| # assay = Assay() |
knirirr
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng from alterations to isatools/model and isatools/database