Low memory XML decoding (parsing scans iteratively) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems a lot cleaner than what we hacked through at first. I'll review it as soon as I can. |
|
Thanks @lomereiter, this is a great contribution. No unit tests yet... but it seems to be passing the travis and Appveyor tests with no problem |
|
Hey @althonos, do you think we should merge this now? or perhaps we should wait until we have the unit test functionality? |
|
Well, since this passes the integration against MetaboLights, I'm positive
about merging (I'm not sure how long it will take to setup unit tests, the
feat-tests may be far behind master).
|
|
Maybe (because of the increased time) we should still leave both methods and let the user choose (like |
|
Yeah I think you are right @althonos, keeping both methods seems like the best idea as memory consumption might not be a problem for some. |
althonos
force-pushed
the
master
branch
2 times, most recently
from
3bbd0f7 to
62b683c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an alternative solution to #13: each scan is parsed once, all necessary information is extracted from it, then the node is freed.
On a large imzML file this brought top memory consumption from 2.5GB down to 90MB, albeit the processing time increased from 6s to 13s.