Skip to content

Conversation

@Tom-Willemsen
Copy link
Member

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Tom-Willemsen Tom-Willemsen moved this to Flash Review in Tasks Apr 30, 2025
Copy link
Contributor

@iangillingham-stfc iangillingham-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change definitely fixes the issue with incorrectly named 'emulator_protocol'. I'm assuming that the properties 'emulator_path' and 'emulator_package' are following the same pattern, so will approve.

@Tom-Willemsen
Copy link
Member Author

@iangillingham-stfc
Copy link
Contributor

I tried to approve this PR, but it only allowed me to leave a comment.

@iangillingham-stfc iangillingham-stfc merged commit 89339c5 into master Apr 30, 2025
4 checks passed
@Tom-Willemsen Tom-Willemsen deleted the fix-typos branch April 30, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants