-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket3071: Add kicker db files #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs minor changes and modbus support
kickerSup/kicker_current.db
Outdated
} | ||
|
||
record(subArray, "$(DAQMX)CURR:DATA") { | ||
field(DESC, "Reads a single raw current val") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This samples ~ 1 in 1000 data points (depending on data rate), which could be quite noisy. This is okay, but only if it's ballpark figure to be giving to the users on an OPI. If it's suspected that this could be used for other purposes then perhaps an average of the points would be better here.
kickerSup/kicker_current.db
Outdated
info(archive, "VAL") | ||
} | ||
|
||
record(calcout, "$(DAQMX)CURR:ACQUIRE:_TRIG") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method of this record is nontrivial, could you put a comment on this record explaining how and why it does what it does?
kickerSup/kicker_current.db
Outdated
field(DESC, "Reads an array of raw current data") | ||
|
||
$(IFNOTRECSIM) field(SCAN,"I/O Intr") | ||
$(IFNOTRECSIM) field(DTYP, "asynFloat64ArrayIn") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dual DTYP
fields here cause the DB unit checker to fail. This will need to be added as an exception to DBUnitChecker before this can be merged. Also applies to the voltage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See DBUnit Checker pull request here
Description of work done
Ticket
#3404