Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket3071: Add kicker db files #1

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2018

Description of work done

  • Created voltage and current records to communicate with the DAQ.
  • Added substitution file for a Modbus record to communicate with the Schneider Electric M580 PLC.

Ticket

#3404

Rory-Potter-Tessella added 2 commits August 28, 2018 13:45
Copy link

@Alistair-McGann-Tessella Alistair-McGann-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs minor changes and modbus support

}

record(subArray, "$(DAQMX)CURR:DATA") {
field(DESC, "Reads a single raw current val")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This samples ~ 1 in 1000 data points (depending on data rate), which could be quite noisy. This is okay, but only if it's ballpark figure to be giving to the users on an OPI. If it's suspected that this could be used for other purposes then perhaps an average of the points would be better here.

info(archive, "VAL")
}

record(calcout, "$(DAQMX)CURR:ACQUIRE:_TRIG") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method of this record is nontrivial, could you put a comment on this record explaining how and why it does what it does?

field(DESC, "Reads an array of raw current data")

$(IFNOTRECSIM) field(SCAN,"I/O Intr")
$(IFNOTRECSIM) field(DTYP, "asynFloat64ArrayIn")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dual DTYP fields here cause the DB unit checker to fail. This will need to be added as an exception to DBUnitChecker before this can be merged. Also applies to the voltage

Copy link
Author

@ghost ghost Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See DBUnit Checker pull request here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant