Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python argument not to import entire site module to each interpreter #959

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

Tom-Willemsen
Copy link
Contributor

@Tom-Willemsen Tom-Willemsen commented Sep 24, 2019

Description of work

Make jaws manager much faster. The option I've added tells jython not to load all "site packages" (i.e. modules we've pip installed) every time it starts. I've checked the OPIs which use non-standard scripts, and they appear to load correctly with this option enabled.

Ticket

ISISComputingGroup/IBEX#4668

Acceptance criteria

On master, point at NIMROD and open their jaws manager screen. Time this (on my machine it takes 10+ seconds).

On this branch, do the same. Should be less than 1s (not really measurable manually)

Unit tests

n/a, configuration change only

System tests

If anyone has ideas about how to automatically system test this I'm open to ideas. I think using squish will be hard because:

  • Getting into the OPI layers from squish is fiddly
  • It will be very prone to race conditions

I will add a manual system test once this is merged

Documentation

n/a


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, and makes it quicker. I have not been able to test it on zoom they have been using their instrument.

@John-Holt-Tessella John-Holt-Tessella merged commit 8058287 into master Oct 18, 2019
@John-Holt-Tessella John-Holt-Tessella deleted the Ticket4668_jawsmanager_performance branch October 18, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants