Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELEASE-3.1.0 - Feature#271 #384

Open
wants to merge 38 commits into
base: develop
Choose a base branch
from
Open

RELEASE-3.1.0 - Feature#271 #384

wants to merge 38 commits into from

Conversation

fran-cesc
Copy link
Collaborator

  • Redireccionado a pestaña soluciones.
  • Visualización de soluciones aceptadas.
  • Se detecta si el usuario ya ha enviado solución.

Comentarios:

  • No en todos los retos se muestra el texto de la solucion, en algunos aparece código java.
  • Cuando clicamos en un related, no detecta si el usuario ha enviado solución.
  • Peticion de User Solution harcodeada ya que user actual es anonym.

fran-cesc and others added 23 commits May 28, 2024 08:39
@fran-cesc
redireccionado a soluciones
b07b19e
@fran-cesc
lint fixed
cbbc803
@fran-cesc
trabajando en anclaje solutions
5ca43a1
@fran-cesc
Merge branch 'develop' into feature#271f
7035d54
@fran-cesc
anclado solutions
9dedb2b
@fran-cesc
solutions cargadas en challenge-info
49c116d
@fran-cesc
working on it
a94d4d5
@fran-cesc
Merge branch 'develop' into feature#271f
2c87d29
@fran-cesc
anclado soluciones arreglado
ae546b2
@fran-cesc
lint fixed
657537c
@fran-cesc
Merge branch 'develop' into feature#271
16df576
@fran-cesc
detectar si solucion enviada
6fe587d
@fran-cesc
changes in model applied
8120893
@fran-cesc
error in json parse solved, 1 error left
9eccc2f
@fran-cesc
all errrors solved
4d4b215
@fran-cesc
working on tests
7660ad4
@fran-cesc
models fixed
4f090e1
@fran-cesc
solution service test
f836a54
@fran-cesc
Merge branch 'develop' into feature#271
b871166
@Yul1b3th
Corrección: Asegurar que la suscripción a activeId se maneje correcta…
8d0979c 
…mente para prevenir múltiples suscripciones

- Añadida una verificación para asegurar que activeIdSubscription sea undefined antes de suscribirse a activeId$.
- Esto previene múltiples suscripciones y asegura que activeId se actualice correctamente desde el servicio.
@Yul1b3th
Merge branch 'feature#271' of https://github.com/IT-Academy-BCN/ita-c…
bf73da9 
…hallenges-frontend into feature#271
@fran-cesc
feature#271 ready
80cf98a
@fran-cesc
RELEASE 3.1.0
40ef5cd
@fran-cesc fran-cesc linked an issue Jun 26, 2024 that may be closed by this pull request
Anclado Solutions / Detalles: al enviar un reto, se han de visualizar las soluciones y detalles disponibles #271
Open
@jonatanvicente
Copy link
Collaborator

Ups.... it seems there is a corrupted file in the PR. In addition, all variables included at environment.ts must be in environment.prod.ts

@fran-cesc fran-cesc reopened this Jul 2, 2024
@jonatanvicente
Copy link
Collaborator

Please, review next details:

  • There are some conflicts (see above)
  • CHANGELOG must be written only in English
  • It seems there is a env var called 'BACKEND_SSO_SOLUTION' at environment.prod with value dummy :(

@fran-cesc
Copy link
Collaborator Author

details fixed.

@fran-cesc fran-cesc reopened this Jul 16, 2024
@jonatanvicente
Copy link
Collaborator

The request is not redirected appropriately (screenshot attached).
Pasted image

fran-cesc and others added 6 commits July 23, 2024 11:58
@fran-cesc
Merge branch 'develop' into feature#271
aa29c9e
@fran-cesc
working with real user
1a33225 
with '#' will be ignored, and an empty message aborts the commit.  # #
Date:      Tue Jul 23 16:16:27 2024 +0200 # # On branch feature#271 #
Changes to be committed: #	modified:
src/app/modules/challenge/components/challenge-info/challenge-info.component.ts
@fran-cesc
fixed library compatibility problems
2b2ed41
@jonatanvicente
Fixing typescript version
7a3ab74
@fran-cesc
dummy user added
e6cf5bb
@fran-cesc
solution service tests
5775e58
@fran-cesc fran-cesc reopened this Jul 28, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanvicente jonatanvicente Awaiting requested review from jonatanvicente

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anclado Solutions / Detalles: al enviar un reto, se han de visualizar las soluciones y detalles disponibles
3 participants
@fran-cesc @jonatanvicente @Yul1b3th