Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traefik router hardcoded priorities #953

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Jan 30, 2025

What do these changes do?

  • Update traefik router hardcoded priorities according to the rules below
    • 1 --> 3
    • 2 --> 6
    • 3 --> 9
    • 10 --> 12
  • Remove unnecessary priority from adminpanels and registry service

This PR introduces some space in-between the routers which we can use to flexibly add new routers. It shouldn't break existing priority hierarchy since numbers <13 are still below any other non-hardcoded priorities.

Remarks for future:

  • Whenever introducing some priorities to traefik routers (or other similar cases) one better to make them spacious to retain flexibility. This case is a good example why "spacious" approach makes sense

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk added the t:enhancement New feature or request label Jan 30, 2025
@YuryHrytsuk YuryHrytsuk added this to the Singularity milestone Jan 30, 2025
@YuryHrytsuk YuryHrytsuk self-assigned this Jan 30, 2025
@YuryHrytsuk YuryHrytsuk marked this pull request as ready for review January 30, 2025 08:52
@YuryHrytsuk YuryHrytsuk merged commit ff02387 into ITISFoundation:main Jan 30, 2025
3 checks passed
@mrnicegyu11
Copy link
Member

I agree w.r.t. making the space of traefik priorities spacious, look good from my side

mrnicegyu11 pushed a commit to mrnicegyu11/osparc-ops-environments that referenced this pull request Feb 3, 2025
* Update traefik router hardcoded priorities

* remove hardcoded priority from adminpanels
mrnicegyu11 added a commit that referenced this pull request Mar 13, 2025
* wip

* Add csi-s3 and have portainer use it

* Change request @Hrytsuk 1GB max portainer volume size

* Arch Linux Certificates Customization

* Add grafana terrform tooling

* Make osparc-config dotenv-precommit pass: Use all caps env-vars

* Refactoring: jinja2 takes .env file path as explicit argument (like in osparc-config)

* Make CI_ENV_FILE vailable in makefile

* Refactor makefile targets

* Add grafana terraform gitignore

* Rename envvar: TF_STATE_S3_GRAFANAKEY

* Remove old scripts, makefile targets

* Remove unused files

* undue arch style commit

* Remove references to Tempo

* CHange request YH: Stop trying tor ecah grafana eventually

* Change request YH: Move tf scripts to terraform folder

* Change request YH: stricter check

* Add files remove typo

* Add terraform fmt pre-commit hook

* Use ansible.env file in lieu of ci.env if available

* Rename and refactor

* wip

* wip

* remove line

* Makefile repo base dir without git

* Grafana terraform ceph fixes

* Fix indentation

* Add manual to traefik redirect capture all rule (#933)

* Introduce rolling docker config / secret update concept 🎉 🚀  (#952)

* fixes

* update comment

* Update traefik router hardcoded priorities (#953)

* Update traefik router hardcoded priorities

* remove hardcoded priority from adminpanels

* Configure redis replicas via ENV (#957)

* Filestash: remove special docker node label (#959)

* rabbit: configurable replicas (#964)

* rabbit: configurable replicas

* clean up

* 💄 minor: Change DNS Server to Quad9 (#967)

* wip

* Add csi-s3 and have portainer use it

* Change request @Hrytsuk 1GB max portainer volume size

* Arch Linux Certificates Customization

* Change DNS server for aws to swiss privacy focused one

* revert wrong commit

---------

Co-authored-by: Dustin Kaiser <[email protected]>

* single replica (#968)

* Remove docker api proxy from validate simcore settings (#972)

* Add appmotiongateway add dalco

* Add appmotiongateway add dalco - 2

* Add appmotiongateway add dalco - 3

* Seperate dalco-staging: disable redis special handling (#976)

* wip

* Add csi-s3 and have portainer use it

* Change request @Hrytsuk 1GB max portainer volume size

* Arch Linux Certificates Customization

* Remove dalco special staging handling

* remove accidental commit

* remove accidental commit

* Remove dalco staging special handling

---------

Co-authored-by: Dustin Kaiser <[email protected]>

* Fix deploy ops failure

* Make curl in ensure_grafana_online_ timeout after 10s

* Timeout in wait_graylog_is_online

* Fix osparc.local pydantic validation failure director-v0

---------

Co-authored-by: Dustin Kaiser <[email protected]>
Co-authored-by: Yury Hrytsuk <[email protected]>
Co-authored-by: Sylvain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants