Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assess ARM images (just discuss dont merge) #966

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Assess ARM images (just discuss dont merge) #966

wants to merge 18 commits into from
+24 −24

Conversation

mrnicegyu11
Copy link
Member

What do these changes do?

Assess ARM images (just discuss dont merge)

Related issue/s

#945

Related PR/s

Checklist

  • I tested and it works

Sorry, something went wrong.

mrnicegyu11 and others added 17 commits October 15, 2024 16:18
@mrnicegyu11
wip
f0d8cf0
@mrnicegyu11
Merge remote-tracking branch 'upstream/main' into main
e906b41
@mrnicegyu11
Merge remote-tracking branch 'upstream/main' into main
14c751d
@mrnicegyu11
Add csi-s3 and have portainer use it
293f63c
@mrnicegyu11
Change request @Hrytsuk 1GB max portainer volume size
f7f72ec
@mrnicegyu11
t push
94cfb76 
Merge remote-tracking branch 'upstream/main'
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
509c717
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
1a65ecf
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
77ee45e
@mrnicegyu11
Arch Linux Certificates Customization
c9c70d6
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
7b8be53
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
bcd61cd
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
58e1030
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
ed8d479
@mrnicegyu11
Merge remote-tracking branch 'upstream/main'
dda6e01
@mrnicegyu11
wip
e0955e8
@mrnicegyu11
Comment which images have arm available
7969267
@mrnicegyu11 mrnicegyu11 added t:dependencies Pull requests that update a dependency file t:infra-ops Adjustments to the way or resources with that microservices are run labels Feb 5, 2025
@mrnicegyu11 mrnicegyu11 added this to the Singularity milestone Feb 5, 2025
@mrnicegyu11 mrnicegyu11 requested a review from sanderegg February 5, 2025 15:47
@mrnicegyu11 mrnicegyu11 self-assigned this Feb 5, 2025
@mrnicegyu11 mrnicegyu11 mentioned this pull request Feb 5, 2025
Open
sanderegg
sanderegg approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in the comments I would not comment images that are ok. And only comment the ones that need a change.

charts/simcore-charts/resource-usage-tracker/templates/tests/test-connection.yaml
@@ -9,7 +9,7 @@ metadata:
spec:
containers:
- name: wget
image: busybox
image: busybox # has arm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: would it not make more sense to put a comment only if the ARM version is not available?
Like in standard when ARM is present, there is nothing to do right?

services/monitoring/docker-compose.yml.j2
@@ -54,7 +54,7 @@ services:
cpus: "0.1"
prometheuscatchall:
hostname: "{% raw %}{{.Service.Name}}{% endraw %}"
image: prom/prometheus:v2.54.0
image: prom/prometheus:v2.54.0 ## arm64 available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference when you write arm64 vs arm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we are only interested in ARM64 which is the latest I think

services/monitoring/docker-compose.yml.j2
@@ -183,7 +183,7 @@ services:
cpus: "0.1"

nvidia-exporter:
image: mindprince/nvidia_gpu_prometheus_exporter:0.1
image: mindprince/nvidia_gpu_prometheus_exporter:0.1 ## No arm support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I guess this one is expected ;)

services/monitoring/docker-compose.yml.j2
@@ -353,7 +353,7 @@ services:
memory: 64M
cpus: "0.1"{% for _stack in MONITORED_STACK_NAMES.split(",") if _stack != "" %}
{{_stack}}-postgres-exporter:
image: bitnami/postgres-exporter:0.15.0
image: bitnami/postgres-exporter:0.15.0 ## arm64 available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have 2 different types of postgres? ah crap the other is a query exporter. my bad.

@mrnicegyu11
Copy link
Member Author

@sanderegg thanks for the review, I am not planning to merge this PR actually, it is just an easy way to collect the assessment :--) I am more curious if you think from what you see a full move to arm also in the ops side is feasible?

@sanderegg
Copy link
Member

@sanderegg thanks for the review, I am not planning to merge this PR actually, it is just an easy way to collect the assessment :--) I am more curious if you think from what you see a full move to arm also in the ops side is feasible?

@mrnicegyu11 well I do not see here many issues. In the worst case, one can also have a ARM machine and a reduced-sized x86 machine where necessary until migration might be done if the costs are going down, it is anyway a win.

@mrnicegyu11
Copy link
Member Author

mrnicegyu11 commented Feb 10, 2025 •
edited
Loading

OK, follow-up todos:

  • Upgrade adminpanels to latest jupyter (which has arm), check that it still works
  • Compile itisfoundation/appmotion-gateway-php-apache-8.2 for ARM
  • Re-Assess itisfoundation/docker-events-exporter:latest, potentially remove or compile for arm.
  • Decide on adonato/query-exporter:2.10.0, missing ARM
  • Decide on oliver006/redis_exporter:v1.62.0-alpine, missing ARM

Personal thoughts:

  • Probably we can remove the docker events exporter
  • The redis-exporter is seldomly used but very powerful for investiging incidents after they happened. It gives some puzzle pieces, e.g. how long was the browser of the client connected.
  • The query-exporter is super nice if it works, and I think Erdem uses it to count the number of logged-in users for s4l-lite in the admin grafana dashboard

Sorry, something went wrong.

@sanderegg sanderegg removed this from the Singularity milestone Feb 24, 2025
@sanderegg sanderegg added this to the The Awakening milestone Feb 24, 2025
@mrnicegyu11
Copy link
Member Author

I have built and pushed itisfoundation/docker-events-exporter:latest for arm64 today

@mrnicegyu11 mrnicegyu11 mentioned this pull request Mar 20, 2025
Open
1 task
@mrnicegyu11
Copy link
Member Author

The referenced PR ports the missing images to ARM, except for the appmotion gateway

@mrnicegyu11
Copy link
Member Author

See https://github.com/ZurichMedTech/appmotion-payments-gateway/pull/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg

@YuryHrytsuk YuryHrytsuk

Assignees

@mrnicegyu11 mrnicegyu11

Labels
t:dependencies Pull requests that update a dependency file t:infra-ops Adjustments to the way or resources with that microservices are run
Projects
None yet
Milestone
The Awakening
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrnicegyu11 @sanderegg