-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️🎨 Improves error handling in the api-server #5866
♻️🎨 Improves error handling in the api-server #5866
Conversation
9a1ec2a
to
ab929b9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5866 +/- ##
=========================================
- Coverage 84.5% 74.5% -10.1%
=========================================
Files 10 301 +291
Lines 214 14514 +14300
Branches 25 205 +180
=========================================
+ Hits 181 10822 +10641
- Misses 23 3640 +3617
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9905e7d
to
f281677
Compare
642fda5
to
14b8dd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and clean! thanks
services/api-server/src/simcore_service_api_server/exceptions/custom_errors.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
5b824ad
to
ba892ea
Compare
services/api-server/src/simcore_service_api_server/exceptions/handlers/_utils.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/exceptions/handlers/_utils.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. Thanks a lot 🚀
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs.py
Show resolved
Hide resolved
b52652e
to
425db35
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
What do these changes do?
In this PR we do an initial refactoring by reorganizing the code base for errors in
simcore_service_api_server
. In this round we place all error logic undersimcore_service_api_server.models.errors
before doing changes in the logicsimcore_service_api_server.exceptions
ApiServerBaseError(OsparcErrorMixin, Exception)
Related issue/s
How to test
services/api-server/tests/unit/test_exceptions.py
Dev-ops checklist