Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ adding docker-api-proxy service ⚠️ #7070

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 23, 2025

What do these changes do?

Why yet another service? It allows to use the docker API from a manager node.
Why is this important? Some services like the dynamic-scheduler require access to it in order to create and remove services and overlay networks (swarm scope network).

Bonuses

  • added a way to combine multiple lifespan generators
  • added shared single docker client tied to the app's lifecycle
  • connected the dynamic-scheduler to the docker-api-proxy

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 35.82090% with 43 lines in your changes missing coverage. Please review.

Project coverage is 87.04%. Comparing base (89d6628) to head (37b1f5d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7070      +/-   ##
==========================================
- Coverage   87.06%   87.04%   -0.02%     
==========================================
  Files        1647     1642       -5     
  Lines       64308    64181     -127     
  Branches     1093     1188      +95     
==========================================
- Hits        55987    55865     -122     
+ Misses       8008     8003       -5     
  Partials      313      313              
Flag Coverage Δ
integrationtests 65.29% <ø> (-0.03%) ⬇️
unittests 86.03% <35.82%> (-0.01%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.53% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.25% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.48% <0.00%> (-0.55%) ⬇️
pkg_settings_library 90.61% <85.71%> (-0.10%) ⬇️
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.30% <ø> (+0.01%) ⬆️
dynamic_scheduler 97.19% <100.00%> (+0.01%) ⬆️
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.06% <ø> (+0.10%) ⬆️
storage 86.22% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.79% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d6628...37b1f5d. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some early comments

@GitHK GitHK requested a review from sanderegg January 23, 2025 13:27
@GitHK GitHK added this to the Singularity milestone Jan 23, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better thanks!
There are a few things to still fix/think about:

  • dockerfile in root mode
  • who closes the aiohttp client?

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

Let's discuss security implications before going ahead.

@GitHK GitHK requested a review from YuryHrytsuk February 4, 2025 13:20
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GitHK please create a ticket to add this service to ops repository and assign to me

@GitHK GitHK requested a review from sanderegg February 10, 2025 08:51
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!, a few last comments

@GitHK
Copy link
Contributor Author

GitHK commented Feb 12, 2025

@Mergifyio queue

Copy link
Contributor

mergify bot commented Feb 12, 2025

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@GitHK GitHK merged commit f9f5df3 into ITISFoundation:master Feb 12, 2025
92 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-docker-socket-via-http-interface branch February 12, 2025 09:50
Copy link
Contributor

mergify bot commented Feb 12, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@GitHK GitHK removed the 🤖-automerge marks PR as ready to be merged for Mergify label Feb 12, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants