-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] UI/UX Data handling: Larger window and list view by default #7160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7160 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 1636 1636
Lines 63958 63958
Branches 1179 1179
=======================================
+ Hits 56081 56084 +3
+ Misses 7565 7562 -3
Partials 312 312
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! just a couple of things...
- do we want to ask for confirmation when deleting (specially folders)
- does deletion work with multiselection?
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Good point. I added a confirmation dialog, and yes, deletion works with multi-selection too. |
|
What do these changes do?
Related issue/s
How to test
Dev-ops checklist