-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Removed tracing lifespan which should be an initialize #7165
🐛 Removed tracing lifespan which should be an initialize #7165
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7165 +/- ##
==========================================
- Coverage 87.66% 87.58% -0.09%
==========================================
Files 1636 1277 -359
Lines 63966 53998 -9968
Branches 1179 651 -528
==========================================
- Hits 56076 47293 -8783
+ Misses 7578 6525 -1053
+ Partials 312 180 -132
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
…ion#7165) Co-authored-by: Andrei Neagu <[email protected]>
What do these changes do?
Locally I did not manage to run the tracing setup, since it was disabled and I did not catch the issue. The
tracing
module only requires an initialize not a lifespan.I have now correctly renamed it, to avoid future doubts.
Related issue/s
dynamic-scheduler
to use it #7149How to test
Dev-ops checklist