Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add storage dummy rpc endpoints for zipping #7202

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Feb 10, 2025

What do these changes do?

  • Add dummy RPC endpoints in storage for handling zipping tasks. A proper implementation will be added by @giancarloromeo
  • As discussed with @odeimaiz these will be propagated to the webserver once we have agreed on the signature.

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Feb 10, 2025
@bisgaard-itis bisgaard-itis added a:storage issue related to storage service UI/UX labels Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 81.38298% with 35 lines in your changes missing coverage. Please review.

Project coverage is 87.02%. Comparing base (2305d68) to head (91003f0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7202      +/-   ##
==========================================
- Coverage   87.04%   87.02%   -0.03%     
==========================================
  Files        1657     1664       +7     
  Lines       64524    64666     +142     
  Branches     1095     1096       +1     
==========================================
+ Hits        56166    56276     +110     
- Misses       8045     8077      +32     
  Partials      313      313              
Flag Coverage Δ
integrationtests 65.32% <100.00%> (+<0.01%) ⬆️
unittests 86.05% <81.38%> (+0.01%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 94.02% <100.00%> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.53% <84.21%> (-0.06%) ⬇️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.28% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.15% <0.00%> (-0.33%) ⬇️
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.46% <100.00%> (ø)
agent 96.46% <ø> (ø)
api_server 90.56% <100.00%> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (-0.10%) ⬇️
director_v2 91.29% <ø> (-0.02%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.19% <100.00%> (+0.32%) ⬆️
storage 86.61% <95.69%> (+0.33%) ⬆️
webclient ∅ <ø> (∅)
webserver 84.84% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2305d68...91003f0. Read the comment docs.

@bisgaard-itis bisgaard-itis changed the title ✨ Add storage rpc endpoints for zipping ✨ Add storage dummy rpc endpoints for zipping Feb 11, 2025
@bisgaard-itis bisgaard-itis added this to the Singularity milestone Feb 11, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review February 11, 2025 09:54
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primarily naming concerns

@bisgaard-itis bisgaard-itis requested a review from GitHK February 13, 2025 14:16
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the directory as suggested

Copy link

@bisgaard-itis bisgaard-itis merged commit 5ac65f7 into ITISFoundation:master Feb 14, 2025
93 of 95 checks passed
@bisgaard-itis bisgaard-itis deleted the 7199-create-storage-workhorse-mode branch February 14, 2025 09:35
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants