-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add storage
dummy rpc endpoints for zipping
#7202
✨ Add storage
dummy rpc endpoints for zipping
#7202
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7202 +/- ##
==========================================
- Coverage 87.04% 87.02% -0.03%
==========================================
Files 1657 1664 +7
Lines 64524 64666 +142
Branches 1095 1096 +1
==========================================
+ Hits 56166 56276 +110
- Misses 8045 8077 +32
Partials 313 313
Continue to review full report in Codecov by Sentry.
|
storage
rpc endpoints for zippingstorage
dummy rpc endpoints for zipping
This reverts commit 6847d11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primarily naming concerns
packages/models-library/src/models_library/api_schemas_rpc_long_running_tasks/tasks.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/storage/zipping.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/tests/integration/test_modules_long_running_tasks.py
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/api/rpc/_zipping.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_rpc_long_running_tasks/tasks.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_rpc_long_running_tasks/tasks.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the directory as suggested
|
What do these changes do?
storage
for handling zipping tasks. A proper implementation will be added by @giancarloromeoRelated issue/s
How to test
Dev-ops checklist