✨ Add exporter code to storage #7218
Open
+563
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 12, 2025 10:33
added 2 commits
February 12, 2025 16:28
…stream-worker-code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7218 +/- ##
==========================================
- Coverage 87.31% 87.24% -0.08%
==========================================
Files 1712 1550 -162
Lines 66429 62729 -3700
Branches 1125 909 -216
==========================================
- Hits 58004 54726 -3278
+ Misses 8105 7733 -372
+ Partials 320 270 -50
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
added 21 commits
February 14, 2025 09:36
…stream-worker-code
…stream-worker-code
…stream-worker-code
…stream-worker-code
…stream-worker-code
…stream-worker-code
added 23 commits
March 19, 2025 15:50
…stream-worker-code
…stream-worker-code
|
GitHK
requested review from
pcrespov,
sanderegg,
matusdrobuliak66 and
giancarloromeo
as code owners
pcrespov
approved these changes
Mar 20, 2025
| @@ -45,7 +46,9 @@ | |||
| ) | |||
|
|
|||
| # Storage basic file ID | |||
| SIMCORE_S3_FILE_ID_RE = rf"^(api|({UUID_RE_BASE}))\/({UUID_RE_BASE})\/(.+)$" | |||
| SIMCORE_S3_FILE_ID_RE = ( | |||
| rf"^(api\/{UUID_RE_BASE}|exports\/\d+|{UUID_RE_BASE}\/{UUID_RE_BASE})\/(.+)$" | |||
There was a problem hiding this comment.
TIP: might be easier to read with a constant ?
Would lead to something like
rf`^{API_PREFIX_RE}|{EXPORTS_USER_RE}|\/{UUID_RE_BASE}\/{UUID_RE_BASE}`\/(.+)$
?
| @pytest.mark.parametrize( | ||
| "object_key", | ||
| [ | ||
| f"api/{UUID_0}/some-random-file.png", |
There was a problem hiding this comment.
Seeing these, I would rather add a union of three patterns
| @@ -334,6 +335,10 @@ async def get_file_access_rights( | |||
| # ownership still not defined, so we assume it is user_id | |||
| return AccessRights.all() | |||
|
|
|||
| if parent == "exports": | |||
There was a problem hiding this comment.
Shared constant or make sure it is synced via tests
| for entry in meta_data_files: | ||
| source_object_keys.add(entry.object_key) | ||
|
|
||
| _logger.debug("will archive '%s' files", len(source_object_keys)) |
There was a problem hiding this comment.
NIONR:log context might be more informative?
| await self.abort_file_upload( | ||
| user_id=user_id, file_id=destination_object_key | ||
| ) | ||
| raise |
There was a problem hiding this comment.
who is handling this exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add functionality in the
simcore_s3_dsmthat allows to export an archive, given a list of S3 object_keys.Expose functionality to the frontend via the celery job endpoint.
Related issue/s
How to test
Dev-ops checklist