Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1848 add permission rights to async jobs #7262

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Feb 21, 2025

What do these changes do?

  • Add permission check to export data endpoint in storage before submitting job to worker
  • Change AsyncJobId from uuid.UUID to strin order to support "embedding" metadata into task name

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (315de3a) to head (7bfc431).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7262      +/-   ##
==========================================
- Coverage   87.11%   86.68%   -0.43%     
==========================================
  Files        1689     1527     -162     
  Lines       65523    62450    -3073     
  Branches     1119      898     -221     
==========================================
- Hits        57081    54136    -2945     
+ Misses       8124     8054      -70     
+ Partials      318      260      -58     
Flag Coverage Δ
integrationtests 65.35% <100.00%> (-0.04%) ⬇️
unittests 85.92% <97.50%> (-0.22%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.53% <100.00%> (-0.01%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.57% <ø> (+0.05%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.08% <ø> (-0.38%) ⬇️
agent 96.46% <ø> (ø)
api_server 90.56% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.73% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.06% <ø> (ø)
director 76.68% <ø> (+0.09%) ⬆️
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.11% <ø> (-0.06%) ⬇️
storage 84.55% <96.00%> (+0.16%) ⬆️
webclient ∅ <ø> (∅)
webserver 84.47% <100.00%> (-0.74%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315de3a...7bfc431. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! thanks

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) February 27, 2025 10:17
@bisgaard-itis bisgaard-itis merged commit 5c9e45b into ITISFoundation:master Feb 27, 2025
92 of 95 checks passed
@bisgaard-itis bisgaard-itis deleted the 1848-add-permission-rights-to-async-jobs branch February 27, 2025 10:19
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants