Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Clean Pydantic model_dumps warnings #7358

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Mar 13, 2025

What do these changes do?

Clean warnings on director-v2 integration tests, also seen on production.

/home/runner/work/osparc-simcore/osparc-simcore/.venv/lib/python3.11/site-packages/pydantic/main.py:426: UserWarning: Pydantic serializer warnings:
    Expected `uuid` but got `str` with value `'e1e2ea96-ce8f-5abc-8712-b8ed312a782c'` - serialized value may not be as expected
    return self.__pydantic_serializer__.to_python(

Cause

The StandardSimcoreDockerLabels object is created using .model_construct and the node_id was a str instead of UUID.

Related issue/s

How to test

cd services/director-v2
pytest -vv --pdb -W error::UserWarning tests/integration/

Dev-ops checklist

@giancarloromeo giancarloromeo added the a:director-v2 issue related with the director-v2 service label Mar 13, 2025
@giancarloromeo giancarloromeo self-assigned this Mar 13, 2025
@giancarloromeo giancarloromeo added this to the The Awakening milestone Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.40%. Comparing base (45ae7a5) to head (3ef87d6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7358      +/-   ##
==========================================
+ Coverage   87.28%   87.40%   +0.11%     
==========================================
  Files        1709     1332     -377     
  Lines       66326    54536   -11790     
  Branches     1124      481     -643     
==========================================
- Hits        57893    47665   -10228     
+ Misses       8113     6739    -1374     
+ Partials      320      132     -188     
Flag Coverage Δ
integrationtests 65.30% <100.00%> (+<0.01%) ⬆️
unittests 84.78% <75.00%> (-1.68%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.74% <100.00%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.59% <ø> (-0.10%) ⬇️
director_v2 83.99% <100.00%> (-7.28%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 84.22% <ø> (-0.08%) ⬇️
webclient ∅ <ø> (∅)
webserver 85.79% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45ae7a5...3ef87d6. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo marked this pull request as ready for review March 13, 2025 16:09
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the description of the PR is incomplete

@giancarloromeo giancarloromeo added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 14, 2025
@giancarloromeo giancarloromeo enabled auto-merge (squash) March 17, 2025 11:49
@giancarloromeo giancarloromeo disabled auto-merge March 18, 2025 14:39
@giancarloromeo giancarloromeo removed the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants