Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️DB maintenance: drop clusters and cluster_to_groups db tables (🗃️) #7373

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 17, 2025

What do these changes do?

  • drop clusters table
  • drop cluster_to_groups table
  • fix codecov syntax

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:database associated to postgres service and postgres-database package t:maintenance Some planned maintenance work labels Mar 17, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 17, 2025
@sanderegg sanderegg self-assigned this Mar 17, 2025
@sanderegg sanderegg changed the title ♻️DB maintenance: remove clusters and cluster_to_groups db tables (🗃️) ♻️DB maintenance: dropclusters and cluster_to_groups db tables (🗃️) Mar 17, 2025
@sanderegg sanderegg changed the title ♻️DB maintenance: dropclusters and cluster_to_groups db tables (🗃️) ♻️DB maintenance: drop clusters and cluster_to_groups db tables (🗃️) Mar 17, 2025
@sanderegg sanderegg force-pushed the maintenance/remove-clusters-db-tables branch from aa23852 to 214ca43 Compare March 17, 2025 15:08
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (dcef4b4) to head (4be3b13).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7373      +/-   ##
==========================================
+ Coverage   85.71%   87.10%   +1.38%     
==========================================
  Files        1649     1450     -199     
  Lines       63818    57553    -6265     
  Branches     1124      538     -586     
==========================================
- Hits        54700    50130    -4570     
+ Misses       8798     7273    -1525     
+ Partials      320      150     -170     
Flag Coverage Δ
integrationtests 65.32% <ø> (-0.02%) ⬇️
unittests 85.91% <100.00%> (+1.29%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.74% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.08% <ø> (-0.14%) ⬇️
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.59% <ø> (-0.10%) ⬇️
director_v2 91.30% <ø> (-0.01%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.07% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (+0.21%) ⬆️
storage 84.34% <100.00%> (∅)
webclient ∅ <ø> (∅)
webserver 80.30% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcef4b4...4be3b13. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrnicegyu11
Copy link
Member

Adresses: ITISFoundation/osparc-issues#1867

@sanderegg sanderegg force-pushed the maintenance/remove-clusters-db-tables branch from 4792736 to 4be3b13 Compare March 17, 2025 17:00
@sanderegg sanderegg merged commit 864190c into ITISFoundation:master Mar 17, 2025
142 of 146 checks passed
@sanderegg sanderegg deleted the maintenance/remove-clusters-db-tables branch March 17, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants