Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Use cursor paginated storage API #7388

Merged
merged 16 commits into from
Mar 19, 2025
Merged

🎨 [Frontend] Use cursor paginated storage API #7388

merged 16 commits into from
Mar 19, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 18, 2025 •
edited
Loading

What do these changes do?

List more than the hard-limited 1000 items per folder by using the cursor pagination.

ListFiles

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Mar 18, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 19, 2025 09:18
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Use cursor pagination in folder 🎨 [Frontend] Use cursor paginated storage API Mar 19, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 19, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Mar 19, 2025
pcrespov
pcrespov approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🎉

GitHK
GitHK approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listing 10k files form s3 is surprisingly fast

@odeimaiz odeimaiz enabled auto-merge (squash) March 19, 2025 13:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 0b0e98d into ITISFoundation:master Mar 19, 2025
57 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@odeimaiz @mrnicegyu11
🎨 [Frontend] Use cursor paginated storage API (ITISFoundation#7388)
5732d63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
The Awakening
Development

Successfully merging this pull request may close these issues.

Frontend: Use paginated storage API
3 participants
@odeimaiz @GitHK @pcrespov