Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] Allow users copy OEC #7394

Merged
merged 22 commits into from
Mar 20, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 19, 2025

What do these changes do?

If the frontend receives an error that contains a supportId, in the Flash Message an extra widget will be shown. This widget will allow users copy the OEC (oSparc Error Code) together with some extra information (url, timestamp, message and studyId) to the clipboard.

OEC

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Mar 19, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 19, 2025 10:47
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 19, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Mar 19, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Allow users copy EOC 🎨 [Frontend] Allow users copy OEC Mar 19, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Please consider these two suggestions

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Left a couple of suggestions more

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.23%. Comparing base (2e67b17) to head (525cb29).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7394      +/-   ##
==========================================
- Coverage   87.33%   87.23%   -0.11%     
==========================================
  Files        1712     1281     -431     
  Lines       66429    53450   -12979     
  Branches     1125      578     -547     
==========================================
- Hits        58019    46627   -11392     
+ Misses       8090     6638    -1452     
+ Partials      320      185     -135     
Flag Coverage Δ
integrationtests 65.28% <30.00%> (-0.07%) ⬇️
unittests 86.18% <58.33%> (-0.32%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.26% <100.00%> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.25% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.90% <50.00%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e67b17...525cb29. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz
Copy link
Member Author

odeimaiz commented Mar 19, 2025

@pcrespov @GitHK

This is where I am:
NoSupportIdInTheMessage

I stop here until you agree on how the message/UI/UX should be.

@pcrespov
Copy link
Member

pcrespov commented Mar 19, 2025

I stop here until you agree on how the message/UI/UX should be.

@GitHK please read #7392 (and the rest of the sub-issues for #7359) and add your comments/wishes there. We started all these changes based on your feedback during the PM2. Please read carefully how we (all) defined the issues under #7359 and suggest changes there so we are a bit more effective in the implementation. thx

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@odeimaiz odeimaiz enabled auto-merge (squash) March 20, 2025 12:48
@odeimaiz odeimaiz merged commit 728db70 into ITISFoundation:master Mar 20, 2025
91 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy OEC to clipboard @odeimaiz
4 participants