-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Allow users copy OEC #7394
🎨 [Frontend] Allow users copy OEC #7394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Please consider these two suggestions
services/static-webserver/client/source/class/osparc/FlashMessenger.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. Left a couple of suggestions more
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7394 +/- ##
==========================================
- Coverage 87.33% 87.23% -0.11%
==========================================
Files 1712 1281 -431
Lines 66429 53450 -12979
Branches 1125 578 -547
==========================================
- Hits 58019 46627 -11392
+ Misses 8090 6638 -1452
+ Partials 320 185 -135
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
@GitHK please read #7392 (and the rest of the sub-issues for #7359) and add your comments/wishes there. We started all these changes based on your feedback during the PM2. Please read carefully how we (all) defined the issues under #7359 and suggest changes there so we are a bit more effective in the implementation. thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
…parc-simcore into feature/eoc-on-error-message
|
What do these changes do?
If the frontend receives an error that contains a
supportId
, in the Flash Message an extra widget will be shown. This widget will allow users copy the OEC (oSparc Error Code) together with some extra information (url, timestamp, message and studyId) to the clipboard.Related issue/s
How to test
Dev-ops checklist