Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 18, 2025

What do these changes do?

  • removes e2e tests from CI (puppeteer)
  • tests are migrated into:
    • tests/e2e-playwright/tests/platform_CI_tests/test_after_logging_in.py (FI @odeimaiz )
    • tests/e2e-playwright/tests/platform_CI_tests/test_metadata.py (FI @odeimaiz )
  • inverted startup phase of up-prod, up-devel, to first start the ops stack and then the simcore stack to improve slightly the performance (as the simcore stack depends on the ops stack)
  • refactored the wait_for_services utility function to look nicer and produce more useful logs
  • fixed warnings during installation of playwright
  • upgraded simcore Traefik to 3.6.1, which is compatible with docker>29.X (FI @YuryHrytsuk @mrnicegyu11 )
  • increased the start period of the migration service as it is slow in the CI it gets killed half way.

For instance setup in the e2e-playwright test now looks like this:
As a consequence, I guess we should pre-pull postgres/redis/rabbit before starting the stack...
image

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Imparable milestone Nov 18, 2025
@sanderegg sanderegg self-assigned this Nov 18, 2025
@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Nov 18, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2025

🧪 CI Insights

Here's what we observed from your CI run for 58cee3b.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sanderegg sanderegg force-pushed the maintenance/fix-e2e-flakyness branch from 88d3f9d to 15417ca Compare November 18, 2025 09:12
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.52%. Comparing base (daf0b87) to head (58cee3b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8605   +/-   ##
=======================================
  Coverage   87.51%   87.52%           
=======================================
  Files        2010     2006    -4     
  Lines       78979    78895   -84     
  Branches     1378     1378           
=======================================
- Hits        69122    69053   -69     
+ Misses       9453     9438   -15     
  Partials      404      404           
Flag Coverage Δ
integrationtests 63.88% <ø> (-0.07%) ⬇️
unittests 86.36% <ø> (+0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 95.30% <ø> (ø)
pkg_celery_library 83.43% <ø> (ø)
pkg_dask_task_models_library 79.37% <ø> (ø)
pkg_models_library 92.83% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 88.03% <ø> (ø)
pkg_service_integration 72.76% <ø> (ø)
pkg_service_library 71.30% <ø> (ø)
pkg_settings_library 90.21% <ø> (ø)
pkg_simcore_sdk 84.58% <ø> (ø)
agent 93.44% <ø> (ø)
api_server 91.37% <ø> (ø)
autoscaling 95.83% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 91.72% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 91.21% <ø> (-0.09%) ⬇️
dynamic_scheduler 96.66% <ø> (ø)
dynamic_sidecar 90.72% <ø> (-0.11%) ⬇️
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.70% <ø> (ø)
resource_usage_tracker 92.27% <ø> (+0.26%) ⬆️
storage 86.62% <ø> (+0.16%) ⬆️
webclient ∅ <ø> (∅)
webserver 86.69% <ø> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf0b87...58cee3b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the maintenance/fix-e2e-flakyness branch 2 times, most recently from dc092d6 to 45d7062 Compare November 18, 2025 16:06
@sanderegg sanderegg marked this pull request as ready for review November 18, 2025 16:09
@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Nov 18, 2025
@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

@sanderegg sanderegg force-pushed the maintenance/fix-e2e-flakyness branch from 99abb15 to ecbe7ef Compare November 18, 2025 22:44
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sanderegg sanderegg force-pushed the maintenance/fix-e2e-flakyness branch from ecbe7ef to d7cce38 Compare November 19, 2025 14:43
@sanderegg sanderegg force-pushed the maintenance/fix-e2e-flakyness branch from d7cce38 to a3c9d31 Compare November 19, 2025 16:09
@mrnicegyu11
Copy link
Member

I'll need to consider the traefik upgrade briefly before approving, that could break things, jfyi

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tldr, but checked the traefik upgrade, this is fine w.r.t. the migration guide from the traefik-developers. 🪨 🚀 thanks a lot

@sonarqubecloud
Copy link

@sanderegg sanderegg merged commit 98fcf86 into ITISFoundation:master Nov 20, 2025
94 checks passed
@sanderegg sanderegg deleted the maintenance/fix-e2e-flakyness branch November 20, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants