-
Notifications
You must be signed in to change notification settings - Fork 32
⬆️🐛Maintenance/fix e2e flakyness #8605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️🐛Maintenance/fix e2e flakyness #8605
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 58cee3b. ✅ Passed Jobs With Interesting Signals
|
88d3f9d to
15417ca
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8605 +/- ##
=======================================
Coverage 87.51% 87.52%
=======================================
Files 2010 2006 -4
Lines 78979 78895 -84
Branches 1378 1378
=======================================
- Hits 69122 69053 -69
+ Misses 9453 9438 -15
Partials 404 404
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dc092d6 to
45d7062
Compare
|
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
99abb15 to
ecbe7ef
Compare
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
ecbe7ef to
d7cce38
Compare
This reverts commit c23fc3c.
d7cce38 to
a3c9d31
Compare
|
I'll need to consider the traefik upgrade briefly before approving, that could break things, jfyi |
mrnicegyu11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tldr, but checked the traefik upgrade, this is fine w.r.t. the migration guide from the traefik-developers. 🪨 🚀 thanks a lot
|



What do these changes do?
up-prod,up-devel, to first start the ops stack and then the simcore stack to improve slightly the performance (as the simcore stack depends on the ops stack)wait_for_servicesutility function to look nicer and produce more useful logsFor instance

setupin the e2e-playwright test now looks like this:As a consequence, I guess we should pre-pull postgres/redis/rabbit before starting the stack...
Related issue/s
How to test
Dev-ops