Conversation
- Extract reusable build_frontend() function from main() - Refactor test fixtures to use build system instead of duplicating logic - Fix test data generation to match Pydantic model expectations - Add gitignore for test data directory - Rename built_frontend fixture to frontend_with_test_data for clarity - Eliminate 40+ lines of duplicated build logic in tests - Maintain dev mode approach (no build step required for tests) - All core functionality tests now pass (29/49 total) Tests now use the same build process as production, ensuring consistency and maintainability while running much faster without build requirements.
- Add lint-tests.yml workflow for GitHub Actions - Run on all branches with Python 3.10, 3.11, 3.12 matrix - Include ruff linting, formatting checks, and all tests - Add Playwright frontend testing with screenshot capture - Add build verification and artifact upload - Include local test-ci.sh script for development
- Use fixed temp directory path instead of random mkdtemp() - Use deterministic timestamp during tests (PYTEST_CURRENT_TEST env var) - Fix test_scenario_based_kdma_filtering to use dynamic ADM selection - Clean existing test data to ensure fresh, consistent state This eliminates all sources of randomness that caused CI failures when tests passed locally but failed in different environments. All 43 tests now pass consistently with identical test data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
CI/CD Infrastructure
.github/workflows/lint-tests.ymlscripts/test-ci.shfor developmentTest Infrastructure Improvements
Test Fixes
Code Quality
Test Coverage
Performance Improvements
-n autoQuality Assurance