Merged
Conversation
PaulHax
force-pushed
the
link-parameters
branch
from
62280c9 to
cc0db6b
Compare
PaulHax
force-pushed
the
link-parameters
branch
from
cc0db6b to
cff9f96
Compare
- Update all JavaScript files to use kdmaValues instead of kdmas - Change URL parameter mapping from 'kdma_values': 'kdmas' to 'kdma_values': 'kdmaValues' - Maintain consistent naming between API JSON format and frontend code - All KDMA-related tests pass, confirming functionality remains intact
…tural ordering Fixes scene parameter ordering so "Probe 1, Probe 2, Probe 10" displays correctly instead of "Probe 1, Probe 10, Probe 11, Probe 2"
- Expose expandableStates to global window object for table-formatter.js access - Save Choice Info section expansion states before re-rendering table - Restore saved expansion states after re-rendering with setTimeout - Add test to verify expansion state persistence across parameter changes
- Reduced table renders from 3 to 1 when changing parameters - Fixed redundant render call in updatePinnedRunState after reloadPinnedRun - Added loading spinner next to title instead of re-rendering table for loading state - Spinner uses visibility instead of display to prevent layout shift - Added tests to monitor render count and spinner functionality
- Replace range input sliders with select dropdowns for KDMA values - Update event handler from handleRunKDMASliderInput to handleRunKDMAValueChange - Remove slider-specific CSS and add dropdown styling - Update all tests to use select_option() instead of fill() for dropdowns - Remove redundant test_kdma_warning_system test - Preserve test intent while adapting for dropdown behavior
PaulHax
force-pushed
the
link-parameters
branch
from
7f7eeaa to
91f28ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.