Updates to support php8.2 #334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: Clean up maketest script to avoid warning on reading export for generate-php Updated ninja_sdk Removed mbstring Replaced @utf8_encode with mb_convert_encoding() Replaced null values with empty string for preg_replace() Save data to a variable before returning Added type-safe conditional fixes Added string interpolation fixes Fixed return type declaration Fixed object initialization before using it Fix errors encountered on functions called by static functions Clean up function with expected return types Converted displayed url strings with htmlspecialchars() Added exception error handling for calling unserialize() Updated preg_split(), removed null with either -1 or empty string Fixed objects and variables that requires global reinitialization Replaced assert_options() with ini_set(assert.option) Replaced strftime() with DateTime() Clean up functions that does not have equal number of expected and sent parameters Replaced utf8_decode() with mb_detect_encoding() Added #[\ReturnTypeWillChange] for overriding method Replaced phpunit @group with #[Group('')] Replaced phpunit @Depends with #[Depends('')] Added phpunit #[DataProvider('')] Replaced snake_case filenames to PascalCase Signed-off-by: Eunice Remoquillo <[email protected]>
This reverts commit 32e2ee8.
This commit fixed the wrong displayed output upon saving empty comments.
This commit removed the pseudo-http code displayed by removing text to int comparison as php8.2 does not allow this. This commit checks if the output has a three digit error code instead. Signed-off-by: Eunice Remoquillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Clean up maketest script to avoid warning on reading export for generate-php
Updated ninja_sdk
Removed mbstring
Replaced @utf8_encode with mb_convert_encoding()
Replaced null values with empty string for preg_replace()
Save data to a variable before returning
Added type-safe conditional fixes
Added string interpolation fixes
Fixed return type declaration
Fixed object initialization before using it
Fix errors encountered on functions called by static functions
Clean up function with expected return types
Converted displayed url strings with htmlspecialchars()
Added exception error handling for calling unserialize()
Updated preg_split(), removed null with either -1 or empty string
Fixed objects and variables that requires global reinitialization
Replaced assert_options() with ini_set(assert.option)
Replaced strftime() with DateTime()
Clean up functions that does not have equal number of expected and sent parameters
Replaced utf8_decode() with mb_detect_encoding()
Added #[\ReturnTypeWillChange] for overriding method
Replaced phpunit @group with #[Group('')]
Replaced phpunit https://github.com/Depends with #[Depends('')]
Added phpunit #[DataProvider('')]
Replaced snake_case filenames to PascalCase