ENH Update to EdDSA signing key#30
Closed
mikenuguid wants to merge 2 commits intoIanSimpson:masterfrom
Closed
Conversation
mikenuguid
commented
Jan 22, 2025
- Updates to a more secure EdDSA algorithm using Ed25519 curve.
- Unit tests updated to use EdDSA signer and pre-generated key pairs
- Updated ReadMe on how to generate key pairs using Ed25519 algorithm
|
@mikenuguid does this change the hash method in general? I'm looking at another system that would require a slightly different one - wondering if we make this a configuration option - eg you can pass in which system you want to use. |
Author
|
Thanks for checking @blueo. Configuration sounds a nice. I'll make changes on this when I get some time. |
Author
|
@blueo I've created a new pull request to replace this. Closing this one too. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.