Skip to content

Internal: Switch from yarn to pnpm#178

Merged
IanVS merged 5 commits intomainfrom
pnpm
Jul 12, 2024
Merged

Internal: Switch from yarn to pnpm#178
IanVS merged 5 commits intomainfrom
pnpm

Conversation

@IanVS
Copy link
Copy Markdown
Owner

@IanVS IanVS commented Jul 12, 2024

It's faster, less buggy than yarn 1.x, and easier to work with than yarn 3/4.

One note: I did not try to migrate the lockfile, so this also updates all dependencies based on semver range in our package.json

Copy link
Copy Markdown
Collaborator

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm wasn’t safe to use with react-native when I last checked (>3 years ago). Is that fixed now?

Forgive a perhaps silly question, but if we do this, it implies a switch from yarn.lock to pnpm-lock.yaml — do package consumers end up seeing that file or no? My brain isn’t fully booted on this one.

@IanVS
Copy link
Copy Markdown
Owner Author

IanVS commented Jul 12, 2024

I'm not sure about pnpm and react-native, but since this isn't a react-native project, I think it's fine. The change will have no impact on consumers of the project, since whatever package manager they are using will be used to install it. So to answer your other question, no, the lock file is not exposed to end-users of a library / package. It's only used by contributors of the project when installing our dependencies and working on the project.

@IanVS IanVS merged commit fef70a6 into main Jul 12, 2024
@IanVS IanVS deleted the pnpm branch July 12, 2024 18:52
@andidev
Copy link
Copy Markdown

andidev commented Nov 26, 2024

pnpm wasn’t safe to use with react-native when I last checked (>3 years ago). Is that fixed now?

Forgive a perhaps silly question, but if we do this, it implies a switch from yarn.lock to pnpm-lock.yaml — do package consumers end up seeing that file or no? My brain isn’t fully booted on this one.

@fbartho
just a note that think it now supports it since version 0.73
https://reactnative.dev/blog/2023/12/06/0.73-debugging-improvements-stable-symlinks#stable-symlink-support-in-metro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants