Re-add importOrderCaseSensitive option for case-sensitive sorting
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a custom natural sort algorithm which allows for numeric natural sorting while also sorting all uppercase letters before all lowercase letters, which is the desired behavior here. For example, when `importOrderCaseSensitive` is false (the default): ```js import ExampleComponent from './ExampleComponent'; import ExamplesList from './ExamplesList'; import ExampleWidget from './ExampleWidget'; ``` Compared with `"importOrderCaseSensitive": true`: ```js import ExampleComponent from './ExampleComponent'; import ExampleWidget from './ExampleWidget'; import ExamplesList from './ExamplesList'; ``` Closes IanVS#151
acnebs
force-pushed
the
add-case-sensitivity
branch
from
3f4656f
to
092a537
Compare
IanVS
requested changes
Sep 27, 2024
| if (aNumber > bNumber) return 1; | ||
| if (aNumber < bNumber) return -1; | ||
| aIndex += aNumericMatch[0].length; | ||
| bIndex += bNumericMatch[0].length; |
There was a problem hiding this comment.
One minor edge case here is if there are different-length strings that evaluate to the same number, like multiple zeroes for instance. We can get this kind of sorting:
"file000a",
"file00a",
"file000b",
"file00z",
On the other hand, that's also how naturalSort sorts them, so I don't think it's a problem.
|
Yep will investigate. |
|
That should fix it @IanVS |
|
Would it be possible to merge this in now that it is passing all checks? |
IanVS
reviewed
Oct 7, 2024
|
Readme updated 👍 |
IanVS
approved these changes
Oct 8, 2024
|
Thanks so much for your work on this! I'll do my best to get a new minor version released soon, but there's a thing or two that I want to squeak in with it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a custom natural sort algorithm which allows for numeric natural sorting while also sorting all uppercase letters before all lowercase letters, which is the desired behavior here.
For example, when
importOrderCaseSensitiveis false (the default):Compared with
"importOrderCaseSensitive": true:Closes #151